From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtcXP-0005Vt-ML for qemu-devel@nongnu.org; Mon, 01 Jul 2013 07:45:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtcXI-0006zf-SX for qemu-devel@nongnu.org; Mon, 01 Jul 2013 07:44:55 -0400 Sender: Paolo Bonzini Message-ID: <51D16BAA.8050207@redhat.com> Date: Mon, 01 Jul 2013 13:44:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130608020048.GA1412@amt.cnet> <20130618233825.GA19042@amt.cnet> <20130625121815.GR18508@redhat.com> In-Reply-To: <20130625121815.GR18508@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: kvm-devel , Glauber Costa , Marcelo Tosatti , qemu-devel , qemu-stable@nongnu.org, Jan Kiszka Il 25/06/2013 14:18, Gleb Natapov ha scritto: > On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote: >> > >> > v2: remove unnecessary runstate_is_running() usage (Paolo) >> > >> > -- >> > >> > kvmclock should not count while vm is paused, because: >> > >> > 1) if the vm is paused for long periods, timekeeping >> > math can overflow while converting the (large) clocksource >> > delta to nanoseconds. >> > >> > 2) Users rely on CLOCK_MONOTONIC to count run time, that is, >> > time which OS has been in a runnable state (see CLOCK_BOOTTIME). >> > >> > Change kvmclock driver so as to save clock value when vm transitions >> > from runnable to stopped state, and to restore clock value from stopped >> > to runnable transition. >> > >> > Signed-off-by: Marcelo Tosatti > > Applied, thanks. Cc: qemu-stable@nongnu.org Gleb, the commit hash is fixed now that you applied the patch---so I cannot just amend it to include the Cc, right? Paolo