From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtfFr-00080u-7O for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtfFp-0005CM-Ig for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:38:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtfFp-0005C4-AY for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:38:57 -0400 Message-ID: <51D1947D.6040309@redhat.com> Date: Mon, 01 Jul 2013 16:38:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372438702-20491-1-git-send-email-pbonzini@redhat.com> <1372438702-20491-6-git-send-email-pbonzini@redhat.com> <51D1924C.5020103@siemens.com> In-Reply-To: <51D1924C.5020103@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 05/11] memory: add ref/unref List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "peter.maydell@linaro.org" , "qemu-devel@nongnu.org" Il 01/07/2013 16:29, Jan Kiszka ha scritto: > Reviewed-by: Jan Kiszka > > BTW, shouldn't object_ref/unref be converted to atomics / > __sync_fetch_and_add/sub? I'm carrying a modified patch by Ping Fan for > this here. Yes, they should. Not necessarily _now_, but certainly before the RCU stuff I posted (which should include call_rcu-ification of the object_finalize call). If you send that patch I'll pick it up as well. Paolo