From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtfSv-0004iT-3I for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:52:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtfSq-0001y2-5d for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:52:29 -0400 Received: from mail-ye0-x22b.google.com ([2607:f8b0:4002:c04::22b]:53420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtfSq-0001xi-1O for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:52:24 -0400 Received: by mail-ye0-f171.google.com with SMTP id q14so1183960yen.2 for ; Mon, 01 Jul 2013 07:52:22 -0700 (PDT) Sender: Richard Henderson Message-ID: <51D197A2.4050706@twiddle.net> Date: Mon, 01 Jul 2013 07:52:18 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1372636487-124064-1-git-send-email-petar.jovanovic@rt-rk.com> In-Reply-To: <1372636487-124064-1-git-send-email-petar.jovanovic@rt-rk.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Petar Jovanovic Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, petar.jovanovic@imgtec.com On 06/30/2013 04:54 PM, Petar Jovanovic wrote: > From: Petar Jovanovic > > This change corrects rounding and saturation of Q31 fractional value in > mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the > corner case for PRECRQ_RS.PH, and this test case is also part of the change. > > Signed-off-by: Petar Jovanovic > --- > > v2: > > - added comments to the code > > target-mips/dsp_helper.c | 16 +++++++++++----- > tests/tcg/mips/mips32-dsp/precrq_rs_ph_w.c | 24 ++++++++++++++++++++---- > 2 files changed, 31 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~