From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries
Date: Mon, 01 Jul 2013 16:53:11 +0200 [thread overview]
Message-ID: <51D197D7.6070102@redhat.com> (raw)
In-Reply-To: <51D1964F.6040904@suse.de>
Il 01/07/2013 16:46, Andreas Färber ha scritto:
>> >
>> > What's wrong with a single makefile for everything, except
>> > of the need to use full pathnames from the top-level source
>> > dir?
> In short the problem we ran into was missing *.d inclusions.
> This got fixed by automatically expanding net/ to -include
> net/Makefile.objs and -include net/*.d or so.
I don't think that's the problem. Simply I don't think that listing
1000 object files in a single makefile are manageable. Choosing the
right directory per-target is also much easier if you can just do
obj-y += hw/$(TARGET_BASE_ARCH)/
instead of long if-elseif-elseif-elseif-endif conditionals.
Conflicts in a small file are also way easier to solve, even if there
are more conflicting files.
If you prefer to have _everything_ in a single file, you just have to
post patches and justify them. I just doubt that the result will be
better than what we have today, and the time would be better invested in
cleaning up what we have today.
Paolo
next prev parent reply other threads:[~2013-07-01 14:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 17:34 [Qemu-devel] [RFC PATCH 0/4] per-object libraries Michael Tokarev
2013-06-18 17:34 ` [Qemu-devel] [RFC PATCH 1/4] build-sys: strip leading ./ from $(obj) Michael Tokarev
2013-06-18 17:34 ` [Qemu-devel] [RFC PATCH 2/4] build-sys: allow object-specific libraries to be used to link executables Michael Tokarev
2013-06-18 17:34 ` [Qemu-devel] [RFC PATCH 3/4] build-sys: allow per-object foo.cflags variables Michael Tokarev
2013-06-18 17:34 ` [Qemu-devel] [RFC PATCH 4/4] build-sys: move -lcurl out of libs and specify it for curl.o Michael Tokarev
2013-06-19 0:41 ` [Qemu-devel] [RFC PATCH 0/4] per-object libraries Michael Tokarev
2013-06-19 14:16 ` Stefan Hajnoczi
2013-06-19 14:58 ` Michael Tokarev
2013-06-19 16:46 ` Paolo Bonzini
2013-06-19 16:58 ` Paolo Bonzini
2013-06-19 18:18 ` Michael Tokarev
2013-06-19 18:52 ` Paolo Bonzini
2013-06-19 19:31 ` Richard Henderson
[not found] ` <51C2D03E.2030505@redhat.com>
2013-06-20 10:06 ` Peter Maydell
2013-06-20 12:39 ` Paolo Bonzini
2013-06-20 12:50 ` Peter Maydell
2013-06-20 17:09 ` Richard Henderson
2013-06-19 20:00 ` Michael Tokarev
2013-06-20 10:09 ` Paolo Bonzini
2013-06-30 15:23 ` Michael Tokarev
2013-07-01 10:08 ` Paolo Bonzini
2013-07-01 10:10 ` Michael Tokarev
2013-07-01 10:18 ` Paolo Bonzini
2013-06-30 15:28 ` Andreas Färber
2013-06-30 15:36 ` Michael Tokarev
2013-06-30 15:51 ` Peter Maydell
2013-06-30 16:49 ` Michael Tokarev
2013-07-01 8:00 ` Stefan Hajnoczi
2013-06-30 15:56 ` Andreas Färber
2013-07-01 13:39 ` Paolo Bonzini
2013-07-01 14:43 ` Michael Tokarev
2013-07-01 14:46 ` Andreas Färber
2013-07-01 14:52 ` Michael Tokarev
2013-07-01 14:53 ` Paolo Bonzini [this message]
2013-07-01 15:06 ` Michael Tokarev
2013-07-01 15:20 ` Paolo Bonzini
2013-07-01 15:52 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D197D7.6070102@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).