From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtfTg-0005gb-VH for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtfTf-00025E-BP for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:53:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtfTf-00025A-3J for qemu-devel@nongnu.org; Mon, 01 Jul 2013 10:53:15 -0400 Message-ID: <51D197D7.6070102@redhat.com> Date: Mon, 01 Jul 2013 16:53:11 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1371576844-28743-1-git-send-email-mjt@msgid.tls.msk.ru> <51D04EA6.6020806@suse.de> <51D05090.40304@msgid.tls.msk.ru> <51D18681.6050805@redhat.com> <51D1959B.50803@msgid.tls.msk.ru> <51D1964F.6040904@suse.de> In-Reply-To: <51D1964F.6040904@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Michael Tokarev , qemu-devel@nongnu.org Il 01/07/2013 16:46, Andreas F=E4rber ha scritto: >> >=20 >> > What's wrong with a single makefile for everything, except >> > of the need to use full pathnames from the top-level source >> > dir? > In short the problem we ran into was missing *.d inclusions. > This got fixed by automatically expanding net/ to -include > net/Makefile.objs and -include net/*.d or so. I don't think that's the problem. Simply I don't think that listing 1000 object files in a single makefile are manageable. Choosing the right directory per-target is also much easier if you can just do obj-y +=3D hw/$(TARGET_BASE_ARCH)/ instead of long if-elseif-elseif-elseif-endif conditionals. Conflicts in a small file are also way easier to solve, even if there are more conflicting files. If you prefer to have _everything_ in a single file, you just have to post patches and justify them. I just doubt that the result will be better than what we have today, and the time would be better invested in cleaning up what we have today. Paolo