qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@gmail.com>,
	Christian Berendt <berendt@b1-systems.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Scott Wood <scottwood@freescale.com>
Subject: Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support
Date: Mon, 01 Jul 2013 18:54:50 +0200	[thread overview]
Message-ID: <51D1B45A.4050103@suse.de> (raw)
In-Reply-To: <51BE1110.5000107@suse.de>

Am 16.06.2013 21:25, schrieb Andreas Färber:
> Am 12.06.2013 22:32, schrieb Scott Wood:
>> Enables support for the in-kernel MPIC that thas been merged into the
>> KVM next branch.  This includes irqfd/KVM_IRQ_LINE support from Alex
>> Graf (along with some other improvements).
>>
>> Note from Alex regarding kvm_irqchip_create():
>>
>>   On x86, one would call kvm_irqchip_create() to initialize an
>>   in-kernel interrupt controller.  That function then goes ahead and
>>   initializes global capability variables as well as the default irq
>>   routing table.
>>
>>   On ppc, we can't call kvm_irqchip_create() because we can have
>>   different types of interrupt controllers.  So we want to do all the
>>   things that function would do for us in the in-kernel device init
>>   handler.
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
[...]
>> ---
>>  default-configs/ppc-softmmu.mak   |    1 +
>>  default-configs/ppc64-softmmu.mak |    1 +
> 
> This breaks KVM-enabled ppcemb-softmmu build with unresolved symbol
> kvm_openpic_connect_vcpu() in e500.o. Fix in my patch:
> 
> http://patchwork.ozlabs.org/patch/251731/

This issue brought up an interesting question:
Why didn't the buildbots report this build breakage on ppc-next branch?

Both of us didn't see any buildbot emails for quite a while - was this
disabled for some reason?

I didn't find the answer in
https://github.com/b1-systems/buildbot/blob/master/qemu-master.cfg
but I noticed that it still has Stefan's rather than Michael's trivial
tree URL.

Looking at
http://buildbot.b1-systems.de/qemu/one_line_per_build
I see that most builders fail due to configure - which I guess points at
lack of compatible libfdt or dtc submodule.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  parent reply	other threads:[~2013-07-01 17:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 20:32 [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support Scott Wood
2013-06-12 20:56 ` Alexander Graf
2013-06-13 11:01 ` Andreas Färber
2013-06-13 17:32   ` Scott Wood
2013-06-14 14:59     ` Andreas Färber
2013-06-14 22:57       ` Scott Wood
2013-06-16 19:11         ` Andreas Färber
2013-06-19 22:25           ` Scott Wood
2013-06-16 18:32 ` [Qemu-devel] [PATCH ppc-next fixup] intc/openpic_kvm: Fix QOM and build issues Andreas Färber
2013-06-16 19:34   ` Andreas Färber
2013-06-16 19:25 ` [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support Andreas Färber
2013-06-19 21:49   ` Scott Wood
2013-07-01 16:54   ` Andreas Färber [this message]
2013-06-16 19:30 ` [Qemu-devel] [PATCH ppc-next fixup v2] intc/openpic_kvm: Fix QOM and build issues Andreas Färber
2013-06-18 12:39   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D1B45A.4050103@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=berendt@b1-systems.de \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=scottwood@freescale.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).