From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uthpz-00083z-PU for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:24:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UthXZ-0000qL-Nf for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:05:27 -0400 Message-ID: <51D1B45A.4050103@suse.de> Date: Mon, 01 Jul 2013 18:54:50 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1371069171-20377-1-git-send-email-scottwood@freescale.com> <51BE1110.5000107@suse.de> In-Reply-To: <51BE1110.5000107@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Christian Berendt Cc: Peter Maydell , Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Gerd Hoffmann , Anthony Liguori , Scott Wood Am 16.06.2013 21:25, schrieb Andreas F=E4rber: > Am 12.06.2013 22:32, schrieb Scott Wood: >> Enables support for the in-kernel MPIC that thas been merged into the >> KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex >> Graf (along with some other improvements). >> >> Note from Alex regarding kvm_irqchip_create(): >> >> On x86, one would call kvm_irqchip_create() to initialize an >> in-kernel interrupt controller. That function then goes ahead and >> initializes global capability variables as well as the default irq >> routing table. >> >> On ppc, we can't call kvm_irqchip_create() because we can have >> different types of interrupt controllers. So we want to do all the >> things that function would do for us in the in-kernel device init >> handler. >> >> Signed-off-by: Scott Wood [...] >> --- >> default-configs/ppc-softmmu.mak | 1 + >> default-configs/ppc64-softmmu.mak | 1 + >=20 > This breaks KVM-enabled ppcemb-softmmu build with unresolved symbol > kvm_openpic_connect_vcpu() in e500.o. Fix in my patch: >=20 > http://patchwork.ozlabs.org/patch/251731/ This issue brought up an interesting question: Why didn't the buildbots report this build breakage on ppc-next branch? Both of us didn't see any buildbot emails for quite a while - was this disabled for some reason? I didn't find the answer in https://github.com/b1-systems/buildbot/blob/master/qemu-master.cfg but I noticed that it still has Stefan's rather than Michael's trivial tree URL. Looking at http://buildbot.b1-systems.de/qemu/one_line_per_build I see that most builders fail due to configure - which I guess points at lack of compatible libfdt or dtc submodule. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg