From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UthVS-0006Yk-1i
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:03:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UthVN-0007cw-GF
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:03:13 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51D1B647.1060806@twiddle.net>
Date: Mon, 01 Jul 2013 10:03:03 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-2-git-send-email-afaerber@suse.de>
In-Reply-To: <1372536117-28167-2-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 01/41] log: Change
 log_cpu_state[_mask]() argument to CPUState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Green <green@moxielogic.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Michael Walle <michael@walle.cc>, PowerPC <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, jan.kiszka@web.de, Aurelien Jarno <aurelien@aurel32.net>

On 06/29/2013 01:01 PM, Andreas Färber wrote:
>          if ((env->cr[0] & CR0_PE_MASK)) {
> +            X86CPU *cpu = x86_env_get_cpu(env);
>              static int count;
>  
>              qemu_log("%6d: v=%02x e=%04x i=%d cpl=%d IP=%04x:" TARGET_FMT_lx
> @@ -1180,7 +1181,7 @@ static void do_interrupt_all(CPUX86State *env, int intno, int is_int,
>                  qemu_log(" env->regs[R_EAX]=" TARGET_FMT_lx, env->regs[R_EAX]);
>              }
>              qemu_log("\n");
> -            log_cpu_state(env, CPU_DUMP_CCOP);
> +            log_cpu_state(CPU(cpu), CPU_DUMP_CCOP);

Not a bug, but I'd like to know your rationale for adding X86CPU *cpu variables
as opposed to CPUState *cs variables?  Especially when the cpu variable is
never used without the cast to CPU.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~