From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uthbn-0000dS-Qb
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:09:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uthbj-0003Vq-Rr
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:09:47 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51D1B7D2.8040604@twiddle.net>
Date: Mon, 01 Jul 2013 10:09:38 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-5-git-send-email-afaerber@suse.de>
In-Reply-To: <1372536117-28167-5-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 04/41] cpu: Introduce
 CPUClass::set_pc() for gdb_set_cpu_pc()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, PowerPC <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, jan.kiszka@web.de, Aurelien Jarno <aurelien@aurel32.net>

On 06/29/2013 01:01 PM, Andreas Färber wrote:
> This moves setting the Program Counter from gdbstub into target code.
> Use uint64_t type as maximum replacement for target_ulong.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  gdbstub.c                   | 39 ++++++---------------------------------
>  include/qom/cpu.h           |  1 +
>  target-alpha/cpu.c          |  8 ++++++++
>  target-arm/cpu.c            |  8 ++++++++
>  target-cris/cpu.c           |  8 ++++++++
>  target-i386/cpu.c           |  8 ++++++++
>  target-lm32/cpu.c           |  8 ++++++++
>  target-microblaze/cpu.c     |  8 ++++++++
>  target-mips/cpu.c           | 14 ++++++++++++++
>  target-openrisc/cpu.c       |  8 ++++++++
>  target-ppc/translate_init.c |  8 ++++++++
>  target-s390x/cpu.c          |  8 ++++++++
>  target-sh4/cpu.c            |  8 ++++++++
>  target-sparc/cpu.c          |  9 +++++++++
>  target-xtensa/cpu.c         |  8 ++++++++
>  15 files changed, 118 insertions(+), 33 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~