From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52032)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uthot-0006yB-TY
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:23:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uthom-0003qf-V5
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:23:19 -0400
Received: from mail-gh0-x22a.google.com ([2607:f8b0:4002:c05::22a]:42532)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uthom-0003qP-PW
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:23:12 -0400
Received: by mail-gh0-f170.google.com with SMTP id z10so2095674ghb.29
	for <qemu-devel@nongnu.org>; Mon, 01 Jul 2013 10:23:12 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51D1BAFC.6070708@twiddle.net>
Date: Mon, 01 Jul 2013 10:23:08 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-25-git-send-email-afaerber@suse.de>
In-Reply-To: <1372536117-28167-25-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 24/41] target-alpha: Change
 DisasContext::env to CPUState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: jan.kiszka@web.de, qemu-devel@nongnu.org

On 06/29/2013 01:01 PM, Andreas Färber wrote:
> -    CPUAlphaState *env;
> +    AlphaCPU *cpu;

Actually, I take this back.  I'd prefer that we simply pull out the two
variables that we need and place them in the DisasContext.  That's the way it
should have been in the first place.

> @@ -3394,7 +3394,7 @@ static inline void gen_intermediate_code_internal(AlphaCPU *cpu,
>      gen_opc_end = tcg_ctx.gen_opc_buf + OPC_MAX_SIZE;
>  
>      ctx.tb = tb;
> -    ctx.env = env;
> +    ctx.cpu = alpha_env_get_cpu(env);

This should have been ctx.cpu = cpu anyway, apparently fixed in the next patch.


r~