From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiNu-0006yu-Cs
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:59:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiEe-0003BD-Vp
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:49:58 -0400
Message-ID: <51D1BE41.40901@suse.de>
Date: Mon, 01 Jul 2013 19:37:05 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372268143-3894-1-git-send-email-afaerber@suse.de>
	<1372268143-3894-6-git-send-email-afaerber@suse.de>
In-Reply-To: <1372268143-3894-6-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 05/14] cpu: Make first_cpu and
 next_cpu CPUState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Igor Mitsyanko <i.mitsyanko@samsung.com>, Evgeny Voevodin <e.voevodin@samsung.com>, Mark Langsdorf <mark.langsdorf@calxeda.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Peter Crosthwaite <peter.crosthwaite@petalogix.com>, Dmitry Solodkiy <d.solodkiy@samsung.com>, =?UTF-8?B?QW5kcmVhcw==?= =?UTF-8?B?IEbDpHJiZXI=?= <andreas.faerber@web.de>, qemu-ppc <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, kvm <kvm@vger.kernel.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Maksim Kozlov <m.kozlov@samsung.com>, Aurelien Jarno <aurelien@aurel32.net>, David Gibson <david@gibson.dropbear.id.au>

Am 26.06.2013 19:35, schrieb Andreas F=C3=A4rber:
> Move next_cpu from CPU_COMMON to CPUState.
> Move first_cpu variable to qom/cpu.h.
>=20
> gdbstub needs to use CPUState::env_ptr for now.
> cpu_copy() no longer needs to save and restore cpu_next.
>=20
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> [AF: Rebased, simplified cpu_copy()]
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

Squashing the following additional conversion after rebase.

Andreas

diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 38f7990..ff86154 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -500,7 +500,6 @@ static DeviceState
*ppce500_init_mpic_kvm(PPCE500Params *params,
                                           qemu_irq **irqs)
 {
     DeviceState *dev;
-    CPUPPCState *env;
     CPUState *cs;
     int r;

@@ -512,9 +511,7 @@ static DeviceState
*ppce500_init_mpic_kvm(PPCE500Params *params,
         return NULL;
     }

-    for (env =3D first_cpu; env !=3D NULL; env =3D env->next_cpu) {
-        cs =3D ENV_GET_CPU(env);
-
+    for (cs =3D first_cpu; cs !=3D NULL; cs =3D cs->next_cpu) {
         if (kvm_openpic_connect_vcpu(dev, cs)) {


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg