From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiOs-0000UX-PT
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:00:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtiBh-0001dW-Vt
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:46:58 -0400
Received: from cantor2.suse.de ([195.135.220.15]:40294 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uti7T-0007Kn-VK
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 13:42:32 -0400
Message-ID: <51D1BF83.6020501@suse.de>
Date: Mon, 01 Jul 2013 19:42:27 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-25-git-send-email-afaerber@suse.de>
	<51D1BAFC.6070708@twiddle.net>
In-Reply-To: <51D1BAFC.6070708@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 24/41] target-alpha: Change
 DisasContext::env to CPUState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org

Am 01.07.2013 19:23, schrieb Richard Henderson:
> On 06/29/2013 01:01 PM, Andreas F=C3=A4rber wrote:
>> -    CPUAlphaState *env;
>> +    AlphaCPU *cpu;
>=20
> Actually, I take this back.  I'd prefer that we simply pull out the two
> variables that we need and place them in the DisasContext.  That's the =
way it
> should have been in the first place.

Fine with me. Do you want to send a patch based on master right away, or
should I do that in v2?

>> @@ -3394,7 +3394,7 @@ static inline void gen_intermediate_code_interna=
l(AlphaCPU *cpu,
>>      gen_opc_end =3D tcg_ctx.gen_opc_buf + OPC_MAX_SIZE;
>> =20
>>      ctx.tb =3D tb;
>> -    ctx.env =3D env;
>> +    ctx.cpu =3D alpha_env_get_cpu(env);
>=20
> This should have been ctx.cpu =3D cpu anyway, apparently fixed in the n=
ext patch.

Oops, I had done alpha first and then prepended the AlphaCPU propagation
alongside the other targets that needed it.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg