From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtiRx-00044K-46 for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:03:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtiRt-0003EY-Oh for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:03:41 -0400 Received: from mail-ye0-x234.google.com ([2607:f8b0:4002:c04::234]:35637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtiRt-0003EO-LQ for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:03:37 -0400 Received: by mail-ye0-f180.google.com with SMTP id r11so1249036yen.11 for ; Mon, 01 Jul 2013 11:03:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <51D1C474.2000901@twiddle.net> Date: Mon, 01 Jul 2013 11:03:32 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1372536117-28167-1-git-send-email-afaerber@suse.de> <1372536117-28167-24-git-send-email-afaerber@suse.de> <51D1B98A.2010908@twiddle.net> <51D1C1AF.7080300@suse.de> In-Reply-To: <51D1C1AF.7080300@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 23/41] target-xtensa: Change gen_intermediate_code_internal() arg to XtensaCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Mike Frysinger , Max Filippov , jan.kiszka@web.de, qemu-devel@nongnu.org On 07/01/2013 10:51 AM, Andreas Färber wrote: > I wonder, all targets seem to implement the same pattern of passing a > hard-coded bool argument to their internal function. > > Is there any reason not to have translate-all.c call the function with > that true/false directly? The idea is to avoid runtime checks for the rare search_pc case. Instead we pass constants to inline functions and transform what would be runtime checks into compile-time optimized code paths. r~