From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UtiVo-0000hq-3f
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:07:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UtiVk-00064B-Ts
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:07:40 -0400
Received: from mail-gh0-x236.google.com ([2607:f8b0:4002:c05::236]:48194)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UtiVk-00063s-P6
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 14:07:36 -0400
Received: by mail-gh0-f182.google.com with SMTP id z15so2100557ghb.41
	for <qemu-devel@nongnu.org>; Mon, 01 Jul 2013 11:07:36 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51D1C563.9030500@twiddle.net>
Date: Mon, 01 Jul 2013 11:07:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-42-git-send-email-afaerber@suse.de>
In-Reply-To: <1372536117-28167-42-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 41/41] cpu: Introduce
 CPUClass::gdb_{read, write}_register()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, jan.kiszka@web.de, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>

On 06/29/2013 01:01 PM, Andreas Färber wrote:
> Replace GET_REG*() macros by gdb_get_reg*() inline functions for
> clarity and drop breaks after return.
> 
> Allows to move target-specific code to new target-*/gdbstub.c files.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

This one's quite hard to read.

I wonder if there's value in splitting out functions one target at a time into
the new gdbstub.c files, and only afterward performing a few minor textual
changes to transform those functions into the CPUClass methods?


r~