From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utkax-0004XC-U5 for qemu-devel@nongnu.org; Mon, 01 Jul 2013 16:21:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Utkat-0001f2-JY for qemu-devel@nongnu.org; Mon, 01 Jul 2013 16:21:07 -0400 Sender: Richard Henderson Message-ID: <51D1E4A5.20408@twiddle.net> Date: Mon, 01 Jul 2013 13:20:53 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1372536117-28167-1-git-send-email-afaerber@suse.de> <1372536117-28167-5-git-send-email-afaerber@suse.de> <51D1B7D2.8040604@twiddle.net> <51D1BB86.8020003@suse.de> <51D1D298.30605@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 04/41] cpu: Introduce CPUClass::set_pc() for gdb_set_cpu_pc() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexander Graf , qemu-devel@nongnu.org, Blue Swirl , Max Filippov , Michael Walle , qemu-ppc , Paul Brook , "Edgar E. Iglesias" , Jan Kiszka , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Aurelien Jarno On 07/01/2013 12:41 PM, Peter Maydell wrote: > Returning to the point, what we're after here is "a type which will hold > a guest virtual address but whose size doesn't depend on the target the > way target_ulong does", right? My inclination is to suggest that we have > a 'vaddr' typedef by analogy with 'hwaddr'; it seems like that might make > code dealing with guest addresses a little more self documenting. I don't > feel very strongly about it though so if people think it's pointless/will > cause problems that's fine. > I agree that vaddr would probably be a good name. r~