From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utl1g-0008J1-Gc for qemu-devel@nongnu.org; Mon, 01 Jul 2013 16:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Utl1f-00056O-Hs for qemu-devel@nongnu.org; Mon, 01 Jul 2013 16:48:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utl1f-00056I-A5 for qemu-devel@nongnu.org; Mon, 01 Jul 2013 16:48:43 -0400 Message-ID: <51D1EB25.2010109@redhat.com> Date: Mon, 01 Jul 2013 22:48:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372438702-20491-1-git-send-email-pbonzini@redhat.com> <1372438702-20491-8-git-send-email-pbonzini@redhat.com> <51D1CB7B.4060005@siemens.com> In-Reply-To: <51D1CB7B.4060005@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "peter.maydell@linaro.org" , "qemu-devel@nongnu.org" Il 01/07/2013 20:33, Jan Kiszka ha scritto: > > This function is not used outside the iothread mutex, so it > > can use ram_list.mru_block. > > Add a comment to qemu_ram_addr_from_host to document this requirement? Right now there is hardly any documentation of what does _not_ require the iothread mutex... basically everything except qemu_safe_ram_ptr and qemu_ram_ptr_length requires it. Paolo