qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Bas van Sisseren <bas@quarantainenet.nl>
Cc: Qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] [slirp] add nextserver support in slirp's dhcp-server
Date: Mon, 01 Jul 2013 14:51:54 -0600	[thread overview]
Message-ID: <51D1EBEA.9010500@redhat.com> (raw)
In-Reply-To: <1371820809-19712-1-git-send-email-bas@quarantainenet.nl>

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On 06/21/2013 07:20 AM, Bas van Sisseren wrote:
> The slirp dhcp-server normally returns its own address as tftp
> nextserver for netbooting. This patch makes that address
> configurable, so it is possible to use an external tftp boot-
> environment.
> 
> Signed-off-by: Bas van Sisseren <bas@quarantainenet.nl>
> ---
>  net/slirp.c      | 10 ++++++++--

> +++ b/qapi-schema.json
> @@ -2537,6 +2537,8 @@
>  # @dhcpstart: #optional the first of the 16 IPs the built-in DHCP server can
>  #             assign
>  #
> +# @nextserver: #optional IP address of BOOTP server
> +#

Please mark this field as '(since 1.6)'.  Does the field work for both
IPv4 and IPv6 addresses?

>  # @dns: #optional guest-visible address of the virtual nameserver
>  #
>  # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP option
> @@ -2563,6 +2565,7 @@
>      '*tftp':      'str',
>      '*bootfile':  'str',
>      '*dhcpstart': 'str',
> +    '*nextserver': 'str',

This is a command addition that libvirt can't take advantage of unless
we get introspection working in a timely manner.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  parent reply	other threads:[~2013-07-01 20:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21 13:20 [Qemu-devel] [PATCH] [slirp] add nextserver support in slirp's dhcp-server Bas van Sisseren
2013-06-24  9:37 ` Stefan Hajnoczi
2013-07-01 20:51 ` Eric Blake [this message]
2013-07-02 13:03   ` Bas van Sisseren
2013-07-02 13:19     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D1EBEA.9010500@redhat.com \
    --to=eblake@redhat.com \
    --cc=bas@quarantainenet.nl \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).