From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtuKm-0006cH-1C for qemu-devel@nongnu.org; Tue, 02 Jul 2013 02:45:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtuKi-0005sd-RM for qemu-devel@nongnu.org; Tue, 02 Jul 2013 02:45:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtuKi-0005s3-Jx for qemu-devel@nongnu.org; Tue, 02 Jul 2013 02:45:00 -0400 Message-ID: <51D27771.6080904@redhat.com> Date: Tue, 02 Jul 2013 08:47:13 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <51D1D04F.3010201@hds.com> In-Reply-To: <51D1D04F.3010201@hds.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Seiji Aguchi Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, dle-develop@lists.sourceforge.net, tomoki.sekiyama@hds.com, pbonzini@redhat.com, lcapitulino@redhat.com On 07/01/13 20:54, Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we often need to know when the problem happens. > > But, currently, there is no timestamp in qemu's error messages. > Therefore, we may not be able to understand the problem based on > error messages. > > [Solution] > Add a timestamp to qemu's error message logged by > error_report() with g_time_val_to_iso8601(). > > Signed-off-by: Seiji Aguchi > --- > Changelog > v4 -> v5 > - Use sizeof() to define TIMESTAMP_LEN. > - Fix descriptions of msg option. > - Rename TIME_H to QEMU_TIME_H. (avoiding double inclusion of qemu/time.h) > - Change argument of qemu_get_timestamp_str to "char *" and "size_t". > - Confirmed msg option is displayed by query-command-line-options. Reviewed-by: Laszlo Ersek Since you plan to post followup patches, please at that time include a one-liner modification: the STEXI-ETEXI section in "qemu-options.hx" still says (right before ETEXI) "(disabled by default)". I think it should be fixed in a followup, not by posting v6. Thanks! Laszlo