From: Paolo Bonzini <pbonzini@redhat.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device
Date: Tue, 02 Jul 2013 13:01:43 +0200 [thread overview]
Message-ID: <51D2B317.9020808@redhat.com> (raw)
In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD00578E1@LONPEX01CL01.citrite.net>
Il 02/07/2013 12:57, Paul Durrant ha scritto:
>>> So the reason to place the device here is TARGET_PAGE_SIZE...
>>> We really need a way to access that value from common code,
>>> somewhere down my TODO list. :/
>>
>> Why does it need to be in pages rather than bytes?
>
> It doesn't necessarily need to be in pages; it's just a more
> convenient quantity than bytes. Since it needs to be a power of 2 I
> could perhaps use an 'order' parameter instead?
I would just use bytes, the power-of-2 requirement can be checked in the
init function (actually it would just be caught by pci_register_bar).
Paolo
next prev parent reply other threads:[~2013-07-02 11:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 8:39 [Qemu-devel] [PATCH] Citrix PV Bus device Paul Durrant
2013-07-02 8:45 ` [Qemu-devel] [Xen-devel] " Jan Beulich
2013-07-02 8:57 ` Paul Durrant
2013-07-02 9:02 ` Ian Campbell
2013-07-02 9:05 ` Paul Durrant
2013-07-03 10:51 ` James Bulpin
2013-07-02 8:56 ` Ian Campbell
2013-07-02 9:14 ` Paul Durrant
2013-07-02 9:56 ` Ian Campbell
2013-07-02 10:15 ` Tim Deegan
2013-07-02 10:23 ` Ian Campbell
2013-07-02 10:31 ` Paul Durrant
2013-07-02 10:48 ` Ian Campbell
2013-07-02 10:54 ` Pasi Kärkkäinen
2013-07-02 10:49 ` Tim Deegan
2013-07-02 10:57 ` Ian Campbell
2013-07-02 12:35 ` Paul Durrant
2013-07-02 12:43 ` Ian Campbell
2013-07-02 12:51 ` Paul Durrant
2013-07-02 13:43 ` Ian Campbell
2013-07-02 13:56 ` Paul Durrant
2013-07-02 14:08 ` Paul Durrant
2013-07-02 14:22 ` Ian Campbell
2013-07-02 13:36 ` Alex Bligh
2013-07-02 13:42 ` Ian Campbell
2013-07-02 16:12 ` Alex Bligh
2013-07-02 12:38 ` Paul Durrant
2013-07-02 10:44 ` Paul Durrant
2013-07-02 10:45 ` [Qemu-devel] " Andreas Färber
2013-07-02 10:52 ` Paul Durrant
2013-07-02 10:54 ` Paolo Bonzini
2013-07-02 10:57 ` Paul Durrant
2013-07-02 11:01 ` Paolo Bonzini [this message]
2013-07-02 11:10 ` Peter Maydell
2013-07-04 8:37 ` Michael S. Tsirkin
2013-07-02 14:43 ` Anthony Liguori
2013-07-02 15:00 ` Paul Durrant
-- strict thread matches above, loose matches on Subject: below --
2013-07-02 14:03 Paul Durrant
2013-07-02 14:58 ` Peter Maydell
2013-07-02 15:02 ` Paul Durrant
2013-07-24 10:19 ` Gerd Hoffmann
2013-07-26 9:51 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2B317.9020808@redhat.com \
--to=pbonzini@redhat.com \
--cc=Paul.Durrant@citrix.com \
--cc=afaerber@suse.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).