From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtyLL-0000E3-QQ for qemu-devel@nongnu.org; Tue, 02 Jul 2013 07:01:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtyLK-0006eO-Eh for qemu-devel@nongnu.org; Tue, 02 Jul 2013 07:01:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtyLK-0006eA-63 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 07:01:54 -0400 Message-ID: <51D2B317.9020808@redhat.com> Date: Tue, 02 Jul 2013 13:01:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372754385-10186-1-git-send-email-paul.durrant@citrix.com> <51D2AF66.8000507@suse.de> <51D2B156.2080103@redhat.com> <9AAE0902D5BC7E449B7C8E4E778ABCD00578E1@LONPEX01CL01.citrite.net> In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD00578E1@LONPEX01CL01.citrite.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: "xen-devel@lists.xen.org" , "Michael S. Tsirkin" , =?ISO-8859-1?Q?Andreas_F=E4rber?= , "qemu-devel@nongnu.org" Il 02/07/2013 12:57, Paul Durrant ha scritto: >>> So the reason to place the device here is TARGET_PAGE_SIZE... >>> We really need a way to access that value from common code, >>> somewhere down my TODO list. :/ >> >> Why does it need to be in pages rather than bytes? > > It doesn't necessarily need to be in pages; it's just a more > convenient quantity than bytes. Since it needs to be a power of 2 I > could perhaps use an 'order' parameter instead? I would just use bytes, the power-of-2 requirement can be checked in the init function (actually it would just be caught by pci_register_bar). Paolo