From: Alexander Graf <agraf@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 1/3] spapr: Use named enum for function remove_hpte
Date: Tue, 02 Jul 2013 14:45:40 +0200 [thread overview]
Message-ID: <51D2CB74.2020709@suse.de> (raw)
In-Reply-To: <1372096130-24994-2-git-send-email-sw@weilnetz.de>
On 06/24/2013 07:48 PM, Stefan Weil wrote:
> The function returned a target_ulong which was made from unnamed enum
> values. The target_ulong was then assigned to an int variable which
> was used in a switch statement.
>
> Using a named enum in both cases makes reviews easier.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
Thanks, applied to ppc-next.
Alex
next prev parent reply other threads:[~2013-07-02 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 17:48 [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings Stefan Weil
2013-06-24 17:48 ` [Qemu-devel] [PATCH 1/3] spapr: Use named enum for function remove_hpte Stefan Weil
2013-07-02 12:45 ` Alexander Graf [this message]
2013-06-24 17:48 ` [Qemu-devel] [PATCH 2/3] spapr: Fix compiler warning for some versions of gcc (h_remove) Stefan Weil
2013-06-24 20:27 ` Paolo Bonzini
2013-06-24 20:35 ` Stefan Weil
2013-06-24 21:07 ` Paolo Bonzini
2013-06-24 17:48 ` [Qemu-devel] [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc (spapr_io_read) Stefan Weil
2013-07-02 12:45 ` Alexander Graf
2013-07-02 20:22 ` Stefan Weil
2013-07-02 20:25 ` Alexander Graf
2013-06-26 8:14 ` [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2CB74.2020709@suse.de \
--to=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).