From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uu1lY-0000RQ-Rq for qemu-devel@nongnu.org; Tue, 02 Jul 2013 10:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uu1lW-0007wj-Pt for qemu-devel@nongnu.org; Tue, 02 Jul 2013 10:41:12 -0400 Received: from david.siemens.de ([192.35.17.14]:33242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uu1lW-0007wb-BV for qemu-devel@nongnu.org; Tue, 02 Jul 2013 10:41:10 -0400 Message-ID: <51D2E683.6000100@siemens.com> Date: Tue, 02 Jul 2013 16:41:07 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1372444009-11544-1-git-send-email-pbonzini@redhat.com> <1372444009-11544-23-git-send-email-pbonzini@redhat.com> In-Reply-To: <1372444009-11544-23-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 22/30] memory: move MemoryListener declaration earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 2013-06-28 20:26, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > include/exec/memory.h | 66 +++++++++++++++++++++++++-------------------------- > 1 file changed, 33 insertions(+), 33 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index aa7a922..913ac45 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -164,6 +164,39 @@ struct MemoryRegion { > NotifierList iommu_notify; > }; > > +typedef struct MemoryListener MemoryListener; > + > +/** > + * MemoryListener: callbacks structure for updates to the physical memory map > + * > + * Allows a component to adjust to changes in the guest-visible memory map. > + * Use with memory_listener_register() and memory_listener_unregister(). > + */ > +struct MemoryListener { > + void (*begin)(MemoryListener *listener); > + void (*commit)(MemoryListener *listener); > + void (*region_add)(MemoryListener *listener, MemoryRegionSection *section); > + void (*region_del)(MemoryListener *listener, MemoryRegionSection *section); > + void (*region_nop)(MemoryListener *listener, MemoryRegionSection *section); > + void (*log_start)(MemoryListener *listener, MemoryRegionSection *section); > + void (*log_stop)(MemoryListener *listener, MemoryRegionSection *section); > + void (*log_sync)(MemoryListener *listener, MemoryRegionSection *section); > + void (*log_global_start)(MemoryListener *listener); > + void (*log_global_stop)(MemoryListener *listener); > + void (*eventfd_add)(MemoryListener *listener, MemoryRegionSection *section, > + bool match_data, uint64_t data, EventNotifier *e); > + void (*eventfd_del)(MemoryListener *listener, MemoryRegionSection *section, > + bool match_data, uint64_t data, EventNotifier *e); > + void (*coalesced_mmio_add)(MemoryListener *listener, MemoryRegionSection *section, > + hwaddr addr, hwaddr len); > + void (*coalesced_mmio_del)(MemoryListener *listener, MemoryRegionSection *section, > + hwaddr addr, hwaddr len); > + /* Lower = earlier (during add), later (during del) */ > + unsigned priority; > + AddressSpace *address_space_filter; > + QTAILQ_ENTRY(MemoryListener) link; > +}; > + > /** > * AddressSpace: describes a mapping of addresses to #MemoryRegion objects > */ > @@ -202,39 +235,6 @@ struct MemoryRegionSection { > bool readonly; > }; > > -typedef struct MemoryListener MemoryListener; > - > -/** > - * MemoryListener: callbacks structure for updates to the physical memory map > - * > - * Allows a component to adjust to changes in the guest-visible memory map. > - * Use with memory_listener_register() and memory_listener_unregister(). > - */ > -struct MemoryListener { > - void (*begin)(MemoryListener *listener); > - void (*commit)(MemoryListener *listener); > - void (*region_add)(MemoryListener *listener, MemoryRegionSection *section); > - void (*region_del)(MemoryListener *listener, MemoryRegionSection *section); > - void (*region_nop)(MemoryListener *listener, MemoryRegionSection *section); > - void (*log_start)(MemoryListener *listener, MemoryRegionSection *section); > - void (*log_stop)(MemoryListener *listener, MemoryRegionSection *section); > - void (*log_sync)(MemoryListener *listener, MemoryRegionSection *section); > - void (*log_global_start)(MemoryListener *listener); > - void (*log_global_stop)(MemoryListener *listener); > - void (*eventfd_add)(MemoryListener *listener, MemoryRegionSection *section, > - bool match_data, uint64_t data, EventNotifier *e); > - void (*eventfd_del)(MemoryListener *listener, MemoryRegionSection *section, > - bool match_data, uint64_t data, EventNotifier *e); > - void (*coalesced_mmio_add)(MemoryListener *listener, MemoryRegionSection *section, > - hwaddr addr, hwaddr len); > - void (*coalesced_mmio_del)(MemoryListener *listener, MemoryRegionSection *section, > - hwaddr addr, hwaddr len); > - /* Lower = earlier (during add), later (during del) */ > - unsigned priority; > - AddressSpace *address_space_filter; > - QTAILQ_ENTRY(MemoryListener) link; > -}; > - > /** > * memory_region_init: Initialize a memory region > * > Reviewed-by: Jan Kiszka Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux