From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uu6jd-0001nO-WE for qemu-devel@nongnu.org; Tue, 02 Jul 2013 15:59:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uu6jY-0003CI-9n for qemu-devel@nongnu.org; Tue, 02 Jul 2013 15:59:33 -0400 Sender: Richard Henderson Message-ID: <51D33119.5050209@twiddle.net> Date: Tue, 02 Jul 2013 12:59:21 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1372793496-7756-1-git-send-email-afaerber@suse.de> In-Reply-To: <1372793496-7756-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qom-cpu 0/5] TCG code generation performance fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Peter Crosthwaite , Mike Frysinger , Anthony Green , qemu-devel@nongnu.org, qemu-stable@nongnu.org, Max Filippov , Michael Walle , "Edgar E. Iglesias" On 07/02/2013 12:31 PM, Andreas Färber wrote: > Hello, > > As Richard explained, the purpose of having separate gen_intermediate_code() > and gen_intermediate_code_pc() functions per target is to compile-optimize > gen_intermediate_code_internal() for the non-_pc case. > > Multiple targets were using static rather than static inline though, fix this. > > I've split these off from my refactorings so that we can backport them to stable, > and I'm rebasing my argument refactoring patches on top. > > No actual performance changes have been benchmarked, these changes serve more > to align our targets as clear examples for new targets such as rl78 and bfin. All: Reviewed-by: Richard Henderson Although we should probably do some benchmarking at some point to see if the duplicated code paths really do improve things over, say, unlikely(). But failing that we should at least have conformity of implementation. r~