From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uu6xP-0007d5-PB
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 16:13:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uu6xO-0000oV-F8
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 16:13:47 -0400
Message-ID: <51D33475.2040405@suse.de>
Date: Tue, 02 Jul 2013 22:13:41 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372793496-7756-1-git-send-email-afaerber@suse.de>
	<51D33119.5050209@twiddle.net>
In-Reply-To: <51D33119.5050209@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu 0/5] TCG code generation
 performance fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Mike Frysinger <vapier@gentoo.org>, Anthony Green <green@moxielogic.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

Am 02.07.2013 21:59, schrieb Richard Henderson:
> On 07/02/2013 12:31 PM, Andreas F=C3=A4rber wrote:
>> Hello,
>>
>> As Richard explained, the purpose of having separate gen_intermediate_=
code()
>> and gen_intermediate_code_pc() functions per target is to compile-opti=
mize
>> gen_intermediate_code_internal() for the non-_pc case.
>>
>> Multiple targets were using static rather than static inline though, f=
ix this.
>>
>> I've split these off from my refactorings so that we can backport them=
 to stable,
>> and I'm rebasing my argument refactoring patches on top.
>>
>> No actual performance changes have been benchmarked, these changes ser=
ve more
>> to align our targets as clear examples for new targets such as rl78 an=
d bfin.
>=20
> All:
> Reviewed-by: Richard Henderson <rth@twiddle.net>
>=20
> Although we should probably do some benchmarking at some point to see i=
f
> the duplicated code paths really do improve things over, say, unlikely(=
).

I did wonder about unlikely() last night, but I thought that's just a
branch optimization whereas inline might avoid some branches in the
first place.

> But failing that we should at least have conformity of implementation.

Thanks, applied to qom-cpu (moving log_cpu_state to qom-cpu-next):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
(If maintainers want to ack/nack, please do.)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg