From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuCFK-00026u-Hs for qemu-devel@nongnu.org; Tue, 02 Jul 2013 21:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuCFJ-0007sv-6U for qemu-devel@nongnu.org; Tue, 02 Jul 2013 21:52:38 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuCFI-0007sh-Jy for qemu-devel@nongnu.org; Tue, 02 Jul 2013 21:52:37 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Jul 2013 11:45:09 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id A63A82BB0051 for ; Wed, 3 Jul 2013 11:52:28 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r631bLxs39321830 for ; Wed, 3 Jul 2013 11:37:21 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r631qReo032390 for ; Wed, 3 Jul 2013 11:52:28 +1000 Message-ID: <51D383CA.6050808@linux.vnet.ibm.com> Date: Wed, 03 Jul 2013 09:52:10 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1372300908-7546-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1372300908-7546-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 0/9] add internal snapshot support at block device level List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, famz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com Any comments for this version? > This series brings internal snapshot support at block devices level, now we > have two three methods to do block snapshot lively: 1) backing chain, > 2) internal one and 3) drive-back up approach. > > Comparation: > Advantages: Disadvantages: > 1) delta data, taken fast, export, size performance, delete slow. > 2) taken fast, delete fast, performance, size delta data, format > 3) performance, export, format taken slow, delta data, size > > I think in most case, saving vmstate in an standalone file is better than > saving it inside qcow2, So suggest treat internal snapshot as block level > methods and not encourage user to savevm in qcow2 any more. > > Implemention details: > To avoid trouble, this serial have hide ID in create interfaces, this make > sure no chaos of ID and name will be introduced by these interfaces. > There is one patch may be common to Pavel's savvm transaction, patch 1/11, > others are not quite related. Patch 1/11 will not set errp when no snapshot > find, since patch 3/11 need to distinguish real error case. > > Next steps to better full VM snapshot: > Improve internal snapshot's export capability. > Better vmstate saving. > > Thanks Kevin to give advisement about how add it in qmp_transaction, oldest > version comes drom Dietmar Maurer. > > v3: > General: > Rebased after Stenfan's driver-backup patch V6. > > Address Eric's comments: > 4/9: grammar fix and better doc. > 5/9: parameter name is mandatory now. grammar fix. > 6/9: redesiged interface: take both id and name as optional parameter, return > the deleted snapshot's info. > > Address Stefan's comments: > 4/9: add '' around %s in message. drop code comments about vm_clock. > 9/9: better doc, refined the code and add more test case. > > > Wenchao Xia (9): > 1 snapshot: new function bdrv_snapshot_find_by_id_and_name() > 2 snapshot: add paired functions for internal snapshot id and name > 3 snapshot: distinguish id and name in snapshot delete > 4 qmp: add internal snapshot support in qmp_transaction > 5 qmp: add interface blockdev-snapshot-internal-sync > 6 qmp: add interface blockdev-snapshot-delete-internal-sync > 7 hmp: add interface hmp_snapshot_blkdev_internal > 8 hmp: add interface hmp_snapshot_delete_blkdev_internal > 9 qemu-iotests: add 056 internal snapshot for block device test case > > block/qcow2-snapshot.c | 68 +++++++++--- > block/qcow2.h | 5 +- > block/rbd.c | 23 ++++- > block/sheepdog.c | 5 +- > block/snapshot.c | 130 +++++++++++++++++++++- > blockdev.c | 191 +++++++++++++++++++++++++++++++ > hmp-commands.hx | 37 ++++++- > hmp.c | 22 ++++ > hmp.h | 2 + > include/block/block_int.h | 5 +- > include/block/snapshot.h | 14 ++- > include/qemu-common.h | 3 + > qapi-schema.json | 67 +++++++++++- > qemu-img.c | 5 +- > qmp-commands.hx | 104 ++++++++++++++++- > savevm.c | 10 ++- > tests/qemu-iotests/056 | 267 ++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/056.out | 5 + > tests/qemu-iotests/group | 1 + > 19 files changed, 926 insertions(+), 38 deletions(-) > create mode 100755 tests/qemu-iotests/056 > create mode 100644 tests/qemu-iotests/056.out > > -- Best Regards Wenchao Xia