From: Paolo Bonzini <pbonzini@redhat.com>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: libaiqing@huawei.com, seiji.aguchi@hds.com, ghammer@redhat.com,
stefanha@gmail.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, vrozenfe@redhat.com,
lcapitulino@redhat.com, lersek@redhat.com, areis@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'
Date: Wed, 03 Jul 2013 17:58:44 +0200 [thread overview]
Message-ID: <51D44A34.6070105@redhat.com> (raw)
In-Reply-To: <20130703154954.20767.5463.stgit@hds.com>
Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto:
> - return ga_install_service(path, log_filepath, fixed_state_dir);
> + if (ga_install_vss_provider()) {
> + return EXIT_FAILURE;
> + }
> + if (ga_install_service(path, log_filepath, fixed_state_dir)) {
> + ga_uninstall_vss_provider();
> + return EXIT_FAILURE;
> + }
> + return 0;
> } else if (strcmp(service, "uninstall") == 0) {
> + ga_uninstall_vss_provider();
> return ga_uninstall_service();
I think this shouldn't be a hard failure. Only the freeze/thaw commands
should fail.
Paolo
next prev parent reply other threads:[~2013-07-03 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 15:49 [Qemu-devel] [PATCH v5 00/11] qemu-ga: fsfreeze on Windows using VSS Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 01/11] configure: Support configuring C++ compiler Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 02/11] Add c++ keywords to QAPI helper script Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 03/11] checkpatch.pl: Check .cpp files Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 04/11] Add a script to extract VSS SDK headers on POSIX system Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 05/11] qemu-ga: Add configure options to specify path to Windows/VSS SDK Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 06/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 07/11] error: Add error_set_win32 and error_setg_win32 Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 08/11] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 09/11] qemu-ga: Call Windows VSS requester in fsfreeze command handler Tomoki Sekiyama
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install' Tomoki Sekiyama
2013-07-03 15:58 ` Paolo Bonzini [this message]
2013-07-03 16:19 ` Tomoki Sekiyama
2013-07-04 12:54 ` Paolo Bonzini
2013-07-05 17:06 ` Tomoki Sekiyama
2013-07-08 13:58 ` Laszlo Ersek
2013-07-08 14:16 ` Tomoki Sekiyama
2013-07-08 14:44 ` Laszlo Ersek
2013-07-03 15:49 ` [Qemu-devel] [PATCH v5 11/11] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command Tomoki Sekiyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D44A34.6070105@redhat.com \
--to=pbonzini@redhat.com \
--cc=areis@redhat.com \
--cc=ghammer@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=libaiqing@huawei.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=seiji.aguchi@hds.com \
--cc=stefanha@gmail.com \
--cc=tomoki.sekiyama@hds.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).