From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35350)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UuPSR-0006az-Ng
	for qemu-devel@nongnu.org; Wed, 03 Jul 2013 11:59:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UuPSQ-0000pq-7Q
	for qemu-devel@nongnu.org; Wed, 03 Jul 2013 11:59:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36481)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UuPSP-0000pZ-Vs
	for qemu-devel@nongnu.org; Wed, 03 Jul 2013 11:59:02 -0400
Message-ID: <51D44A34.6070105@redhat.com>
Date: Wed, 03 Jul 2013 17:58:44 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20130703154903.20767.27940.stgit@hds.com>
	<20130703154954.20767.5463.stgit@hds.com>
In-Reply-To: <20130703154954.20767.5463.stgit@hds.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS
 provider on `qemu-ga -s install'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: libaiqing@huawei.com, seiji.aguchi@hds.com, ghammer@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, vrozenfe@redhat.com, lcapitulino@redhat.com, lersek@redhat.com, areis@redhat.com

Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto:
> -                return ga_install_service(path, log_filepath, fixed_state_dir);
> +                if (ga_install_vss_provider()) {
> +                    return EXIT_FAILURE;
> +                }
> +                if (ga_install_service(path, log_filepath, fixed_state_dir)) {
> +                    ga_uninstall_vss_provider();
> +                    return EXIT_FAILURE;
> +                }
> +                return 0;
>              } else if (strcmp(service, "uninstall") == 0) {
> +                ga_uninstall_vss_provider();
>                  return ga_uninstall_service();

I think this shouldn't be a hard failure.  Only the freeze/thaw commands
should fail.

Paolo