From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uuj3b-0005a7-PP
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 08:54:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uuj3Y-0003Vs-Sm
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 08:54:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14347)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uuj3Y-0003Vh-JZ
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 08:54:40 -0400
Message-ID: <51D5707E.2040206@redhat.com>
Date: Thu, 04 Jul 2013 14:54:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CDF9C62B.38CC%Tomoki.Sekiyama@hds.com>
In-Reply-To: <CDF9C62B.38CC%Tomoki.Sekiyama@hds.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS
 provider on `qemu-ga -s install'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: "libaiqing@huawei.com" <libaiqing@huawei.com>, Seiji Aguchi <seiji.aguchi@hds.com>, "ghammer@redhat.com" <ghammer@redhat.com>, "stefanha@gmail.com" <stefanha@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>, "vrozenfe@redhat.com" <vrozenfe@redhat.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "lersek@redhat.com" <lersek@redhat.com>, "areis@redhat.com" <areis@redhat.com>

Il 03/07/2013 18:19, Tomoki Sekiyama ha scritto:
> On 7/3/13 11:58 , "Paolo Bonzini" <pbonzini@redhat.com> wrote:
> 
>> Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto:
>>> -                return ga_install_service(path, log_filepath,
>>> fixed_state_dir);
>>> +                if (ga_install_vss_provider()) {
>>> +                    return EXIT_FAILURE;
>>> +                }
>>> +                if (ga_install_service(path, log_filepath,
>>> fixed_state_dir)) {
>>> +                    ga_uninstall_vss_provider();
>>> +                    return EXIT_FAILURE;
>>> +                }
>>> +                return 0;
>>>              } else if (strcmp(service, "uninstall") == 0) {
>>> +                ga_uninstall_vss_provider();
>>>                  return ga_uninstall_service();
>>
>> I think this shouldn't be a hard failure.  Only the freeze/thaw commands
>> should fail.
>>
>> Paolo
> 
> Do you mean that qemu-ga should work without qga-provider.dll etc.
> even if it is configured --with-vss-sdk ?

Yes, and I'm even wondering if we should move all VSS code to a DLL
(provider and requestor---they are very tied to each other anyway
because of hEventFrozen/hEventThaw), and have qemu-ga simply look for
qga-provider.dll dropped into the executable directory.

Then qemu-ga can look for it even if it is not configured --with-vss-sdk.

This is because the license of the SDK may be problematic for
distributions that compile qemu-ga from source.  These distribution
cannot distribute the SDK, and thus they will not be able to compile and
distribute the provider DLL.  Still, we should make it as easy as
possible to combine a DLL and executable from separate sources
into---for example---a single MSI.

Paolo