From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44454)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UulF0-0008If-75
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 11:14:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UulEz-0004uk-99
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 11:14:38 -0400
Received: from cantor2.suse.de ([195.135.220.15]:50458 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UulEz-0004ub-0i
	for qemu-devel@nongnu.org; Thu, 04 Jul 2013 11:14:37 -0400
Message-ID: <51D59158.20602@suse.de>
Date: Thu, 04 Jul 2013 17:14:32 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372943363-24081-1-git-send-email-armbru@redhat.com>
	<1372943363-24081-4-git-send-email-armbru@redhat.com>
	<CAFEAcA-VkvuUpKkb-XS3K+XOYqg=mUNEjwt1OAyodv1MGEdBjA@mail.gmail.com>
In-Reply-To: <CAFEAcA-VkvuUpKkb-XS3K+XOYqg=mUNEjwt1OAyodv1MGEdBjA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/7] vl: New qemu_get_machine_opts()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Am 04.07.2013 16:38, schrieb Peter Maydell:
> On 4 July 2013 14:09, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> +/**
>> + * Get machine options
>> + *
>> + * Returns: machine options (never null).
>> + */
>> +QemuOpts *qemu_get_machine_opts(void)
>> +{
>> +    QemuOptsList *list;
>> +    QemuOpts *opts;
>> +
>> +    list =3D qemu_find_opts("machine");
>> +    assert(list);
>> +    opts =3D qemu_opts_find(list, NULL);
>> +    if (!opts) {
>> +        opts =3D qemu_opts_create_nofail(list);
>> +    }
>> +    return opts;
>> +}
>=20
> This looks a bit odd -- why are we creating new
> options in a function that claims to only be querying
> them?

It's called the Singleton pattern. :P
We use it for the /machine Object, for instance.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg