Re: [Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allocated

[Paolo Bonzini <pbonzini@redhat.com>]

Il 05/07/2013 11:19, Stefan Hajnoczi ha scritto:
> >              /* If the cluster is allocated, we don't need to take action */
> >              ret = bdrv_is_allocated(bs, sector, n, &n);
> > +            if (ret < 0) {
> > +                error_report("error while reading from file");
> > +                goto out;
> > +            }
> 
> We should print the errno valid and saying "while reading from file" is
> a little misleading:
> 
> "error while checking cluster allocation status: %d", ret

I think this is too specific.  In the end, errors from bdrv_is_allocated
are almost always due to a problem reading the metadata from the file.
I will change it to "error reading image metadata", or something like that.

(And also use strerror).

Paolo