From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvXUS-0000Gr-Mq for qemu-devel@nongnu.org; Sat, 06 Jul 2013 14:45:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UvXUR-0005Xu-H2 for qemu-devel@nongnu.org; Sat, 06 Jul 2013 14:45:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34351 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvXUQ-0005Wy-S1 for qemu-devel@nongnu.org; Sat, 06 Jul 2013 14:45:47 -0400 Message-ID: <51D865D5.5060608@suse.de> Date: Sat, 06 Jul 2013 20:45:41 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1372536117-28167-1-git-send-email-afaerber@suse.de> <1372536117-28167-40-git-send-email-afaerber@suse.de> <51D813DC.2050400@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 39/41] target-xtensa: Introduce XtensaCPU subclasses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: jan.kiszka@web.de, qemu-devel@nongnu.org Hi Max, Am 06.07.2013 20:01, schrieb Max Filippov: > On Sat, Jul 6, 2013 at 4:55 PM, Andreas F=C3=A4rber = wrote: >> Am 29.06.2013 22:01, schrieb Andreas F=C3=A4rber: >>> Register a CPU type per core registered. Save the XtensaConfig in >>> XtensaCPUClass instead of CPUXtensaState. >>> >>> Prepares for storing per-class GDB register count. >>> >>> Signed-off-by: Andreas F=C3=A4rber >> >> Ping! Can you ack? (It did not seem to break your test image.) >=20 > I tried make check -C tests/tcg/xtensa with the branch you recommended > and it segfaults on elf loading: That's weird, I'm seeing a similar breakage with the test image on today's qom-cpu-11 branch. It is not caused by this commit though, so must be something I reordered last minute... sorry. The make command above was not working, I've sent a patch for out-of-tree builds and to update it to the current tree layout with tcg/ subdirectory. Andreas > #0 object_class_dynamic_cast_assert (class=3D0x0, > typename=3Dtypename@entry=3D0x55555573a85e "cpu", > file=3Dfile@entry=3D0x5555557349c8 > "/home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/include/qom/cpu.h", > line=3Dline@entry=3D290, func=3Dfunc@entry=3D > 0x555555735770 <__func__.17127> "cpu_get_phys_page_debug") at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/qom/object.c:535 > #1 0x00005555556b884b in cpu_get_phys_page_debug (addr=3D3489660928, > cpu=3D0x555556275a30) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/include/qom/cpu.h:290 > #2 translate_phys_addr (env=3D0x555556275a30, addr=3D3489660928) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/hw/xtensa/xtensa_sim.c:37 > #3 0x0000555555602b9b in load_elf32 (clear_lsb=3D0, elf_machine=3D94, > highaddr=3D0x0, lowaddr=3D0x7fffffffd3b0, pentry=3D0x7fffffffd3a8, > must_swab=3D, translate_opaque=3D0x555556275a30, > translate_fn=3D > 0x5555556b8800 , fd=3D10, name=3D0x555556267df= 0 > "./test_b.tst") at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/include/hw/elf_ops.h:269 > #4 load_elf (filename=3Dfilename@entry=3D0x555556267df0 "./test_b.tst"= , > translate_fn=3Dtranslate_fn@entry=3D0x5555556b8800 , > translate_opaque=3Dtranslate_opaque@entry=3D0x555556275a30, > pentry=3Dpentry@entry=3D > 0x7fffffffd3a8, lowaddr=3Dlowaddr@entry=3D0x7fffffffd3b0, > highaddr=3Dhighaddr@entry=3D0x0, big_endian=3Dbig_endian@entry=3D0, > elf_machine=3Delf_machine@entry=3D94, clear_lsb=3Dclear_lsb@entry=3D0) > at /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/hw/core/loader.c:326 > #5 0x00005555556b8a23 in xtensa_sim_init (args=3D) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/hw/xtensa/xtensa_sim.c:94 > #6 0x000055555559cf6f in main (argc=3D, argv=3D out>, envp=3D) at > /home/jcmvbkbc/ws/m/awt/emu/xtensa/qemu/vl.c:4286 >=20 > The mainline is ok. >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg