From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UvY0g-0008FS-7Z
	for qemu-devel@nongnu.org; Sat, 06 Jul 2013 15:19:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UvY0e-00089t-Tf
	for qemu-devel@nongnu.org; Sat, 06 Jul 2013 15:19:06 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35160 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UvY0e-00089n-M5
	for qemu-devel@nongnu.org; Sat, 06 Jul 2013 15:19:04 -0400
Message-ID: <51D86DA1.4060503@suse.de>
Date: Sat, 06 Jul 2013 21:18:57 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372536117-28167-1-git-send-email-afaerber@suse.de>
	<1372536117-28167-42-git-send-email-afaerber@suse.de>
	<51D1C563.9030500@twiddle.net>
In-Reply-To: <51D1C563.9030500@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu 41/41] cpu: Introduce
 CPUClass::gdb_{read, write}_register()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, jan.kiszka@web.de, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>

Am 01.07.2013 20:07, schrieb Richard Henderson:
> On 06/29/2013 01:01 PM, Andreas F=C3=A4rber wrote:
>> Replace GET_REG*() macros by gdb_get_reg*() inline functions for
>> clarity and drop breaks after return.
>>
>> Allows to move target-specific code to new target-*/gdbstub.c files.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> This one's quite hard to read.

True. Apart from the IMO too generically named GET_REG*() macros, I
needed to fix an awful number of Coding Style issues, which we might
want to do upfront. I could also do the GET_REG*() -> gdb_get_reg*()
sweep in place and split off the break cleanups, too.

> I wonder if there's value in splitting out functions one target at a ti=
me into
> the new gdbstub.c files, and only afterward performing a few minor text=
ual
> changes to transform those functions into the CPUClass methods?

That's not so easy, but I'll think of something. #include'ing the C
files until the final change to CPUClass hooks might work...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg