From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uw08Q-00036N-NX
	for qemu-devel@nongnu.org; Sun, 07 Jul 2013 21:20:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uw08P-0008La-EK
	for qemu-devel@nongnu.org; Sun, 07 Jul 2013 21:20:58 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37761 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uw08O-0008LU-UF
	for qemu-devel@nongnu.org; Sun, 07 Jul 2013 21:20:57 -0400
Message-ID: <51DA13F0.2060400@suse.de>
Date: Mon, 08 Jul 2013 03:20:48 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1372673778.git.hutao@cn.fujitsu.com>
	<c3f77354131c2b74417985577a7da73579c7e7fe.1372673778.git.hutao@cn.fujitsu.com>
In-Reply-To: <c3f77354131c2b74417985577a7da73579c7e7fe.1372673778.git.hutao@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 07/26] q35: use realize for q35 host
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

Am 01.07.2013 12:18, schrieb Hu Tao:
> and split off memory region initialization into instance_init.
>=20
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  hw/pci-host/q35.c | 29 +++++++++++++++--------------
>  1 file changed, 15 insertions(+), 14 deletions(-)

Thanks, rebased and applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next

As mentioned, pci_bus_new() in realize should be replaced with
pci_bus_new_inplace() in instance_init. However investigating that, I
noticed that either function registers VMState, which is supposed to be
done at realize time. This being a system chipset device, I think we can
get away with that (same as for PReP), but I'll do it in a follow-up so
that the blame goes on me.

I think the long-term solution would be extending our realize/unrealize
mechanisms to BusClass.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg