From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Corentin Chary <corentincj@iksaif.net>,
Alex Bligh <alex@alex.org.uk>
Subject: Re: [Qemu-devel] [PATCH] Spelling fixes
Date: Mon, 08 Jul 2013 06:43:54 +0200 [thread overview]
Message-ID: <51DA438A.8060903@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA9V_THiPwVwv-gYH14h2kujDnWpGAOSBd95C9W56p3AuQ@mail.gmail.com>
Am 08.07.2013 00:32, schrieb Peter Maydell:
> On 7 July 2013 23:05, Alex Bligh <alex@alex.org.uk> wrote:
>>
>> --On 7 July 2013 22:25:02 +0200 Stefan Weil <sw@weilnetz.de> wrote:
>>
>>> --- a/ui/vnc-enc-zywrle.h
>>> +++ b/ui/vnc-enc-zywrle.h
>>> @@ -305,9 +305,9 @@ static inline void harr(int8_t *px0, int8_t *px1)
>>> |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1
>>>
>>> In this method, H/L and X0/X1 is always same position.
>>> - This lead us to more speed and less memory.
>>> - Of cause, the result of both method is quite same
>>> - because it's only difference that coefficient position.
>>> + This leads us to more speed and less memory.
>>> + Of course, the result of both methods is quite same
>>> + because its only difference is that coefficient position.
>>> */
>>> static inline void wavelet_level(int *data, int size, int l, int
>>> skip_pixel) {
>>
>> If we're doing spelling/grammar fixes, that should be "is quite the same"
>> and "that of coefficient position".
> "is quite the same" isn't idiomatic English either. I can't
> tell if the author meant "is quite similar" or "is exactly
> the same", so we probably shouldn't change the text unless
> we can work out which one is right...
>
> -- PMM
Thank you for both answers. Even as non native speaker
I was aware that this part still did not sound like correct English,
but I restricted my modifications to those parts where I was sure.
Let's ask the original author Corentin Chary...
Regards
Stefan W.
next prev parent reply other threads:[~2013-07-08 4:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 20:25 [Qemu-devel] [PATCH] Spelling fixes Stefan Weil
2013-07-07 22:05 ` Alex Bligh
2013-07-07 22:32 ` Peter Maydell
2013-07-08 4:43 ` Stefan Weil [this message]
2013-07-08 15:14 ` Corentin Chary
2013-10-10 19:11 ` Stefan Weil
2013-10-11 1:34 ` Peter Maydell
2013-10-11 6:09 ` Stefan Weil
2013-10-11 18:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DA438A.8060903@weilnetz.de \
--to=sw@weilnetz.de \
--cc=alex@alex.org.uk \
--cc=aliguori@us.ibm.com \
--cc=corentincj@iksaif.net \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).