From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwOh2-0003Rb-Hh for qemu-devel@nongnu.org; Mon, 08 Jul 2013 23:34:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwOgz-0002Jx-5u for qemu-devel@nongnu.org; Mon, 08 Jul 2013 23:34:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwOgy-0002Jk-UI for qemu-devel@nongnu.org; Mon, 08 Jul 2013 23:34:17 -0400 Message-ID: <51DB84AE.5040803@redhat.com> Date: Mon, 08 Jul 2013 21:34:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372931597-28115-1-git-send-email-gaowanlong@cn.fujitsu.com> <1372931597-28115-2-git-send-email-gaowanlong@cn.fujitsu.com> <20130705184115.GP13956@otherpad.lan.raisama.net> <51DB0CD1.7030501@redhat.com> <87txk4q2f2.fsf@codemonkey.ws> <51DB835F.9080906@cn.fujitsu.com> In-Reply-To: <51DB835F.9080906@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2UXGHMJSDANHDHCQRHESO" Subject: Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: gaowanlong@cn.fujitsu.com Cc: Anthony Liguori , Eduardo Habkost , qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2UXGHMJSDANHDHCQRHESO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/08/2013 09:28 PM, Wanlong Gao wrote: >>>>> >>>>> Note that after this patch, the defalut suffix of "-numa node,mem=3D= N" >>>>> will no longer be "M". So we must add the suffix "M" like "-numa no= de,mem=3DNM" >>>>> when assigning "N MB" of node memory size. >>>> >=20 > But if we follow Paolo's suggestion like: > -numa node,nodeid=3D0,cpus=3D0 -numa node,nodeid=3D1,cpus=3D1 \ > -numa mem,nodeid=3D0,size=3D1G,policy=3Dmembind,hostnode=3D0-1 > -numa mem,nodeid=3D1,size=3D2G,policy=3Dinterleave,hostnode=3D1 >=20 > We already break the command line compatibility. New command options can have whatever syntax makes sense. The worry here is that if you use the old command line without any new options, the old syntax must behave the same. > Why not change it be a really "size" options without default suffix? Because users are annoyed when a command line that worked with qemu 1.5 needlessly fails to work with qemu 1.6. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2UXGHMJSDANHDHCQRHESO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR24SuAAoJEKeha0olJ0Nq6AkH/RmEKYOJkJCaKQibXPrW6KfR GjApwmPstseK78GiIXG6Ue2i7hyeqo3qwn2+6CWA139rJZ5tZev54kCKj4rWaBgP QsaLFwwhnsFns2mPoPRCJwnMQ7jnxSylHy6e+A+E49F4+AarewigWPZN/drNO+yq joKuiw3n1mieCTGfE9bRJQpiOFsD7f3ifAOsUcvCu41U2ZnSUIYce97AZ3vpvusc r051fzJETBtW2otdEkI4F5+KlDnktiIO4OoXgMTX2CjpOs9wYfI0EB1rcFNJgeZL QjFlowB6YOMrWNeVeQFdJpqaCym7dRj+Ggi+Z1zE3YIkbEVkjvlWU4/Z1xUi7IM= =U2Ry -----END PGP SIGNATURE----- ------enig2UXGHMJSDANHDHCQRHESO--