From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UwSWp-0007pf-Jr
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 03:40:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UwSWm-0000bs-QN
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 03:40:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UwSWm-0000bb-Hg
	for qemu-devel@nongnu.org; Tue, 09 Jul 2013 03:40:00 -0400
Message-ID: <51DBBED3.1040907@redhat.com>
Date: Tue, 09 Jul 2013 09:42:11 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <51D4E5D6.6050404@hds.com> <20130708141749.1cc166ac@redhat.com>
	<A5ED84D3BB3A384992CBB9C77DEDA4D443E1B1A6@USINDEM103.corp.hds.com>
	<20130708150012.748e2cd5@redhat.com>
In-Reply-To: <20130708150012.748e2cd5@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>, "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "stefanha@gmail.com" <stefanha@gmail.com>, "mtosatti@redhat.com" <mtosatti@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "armbru@redhat.com" <armbru@redhat.com>, "dle-develop@lists.sourceforge.net" <dle-develop@lists.sourceforge.net>, Tomoki Sekiyama <tomoki.sekiyama@hds.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, Seiji Aguchi <seiji.aguchi@hds.com>

On 07/08/13 21:00, Luiz Capitulino wrote:
> On Mon, 8 Jul 2013 18:47:24 +0000
> Seiji Aguchi <seiji.aguchi@hds.com> wrote:
> 
>>>> +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
>>>> +    "-msg timestamp[=on|off]\n"
>>>> +    "                change the format of messages\n"
>>>> +    "                on|off controls leading timestamps (default:on)\n",
>>>
>>> Did you really intend to say it's on by default? Because it's actually
>>> disabled by default. I prefer having this disabled btw, and I can fix it
>>> myself before applying if that's what you intended.
>>
>>
>> My default  is "-msg timestamp".
>> Why do you think it is actually disabled by default?
> 
> Oh, for some reason I assumed you wanted the timestamps to show up
> even when -msg is not passed. But now I see that it's on by default
> only if -msg timestamp is passed. Seems reasonable.

Yeah the "(default: XXX)" statements in "qemu-options.hx" keep confusing
me too. They don't document the default qemu behavior (ie. with the
option absent) but the default behavior of the specific option, if given
on the command line :)

> Applied to the qmp branch, thanks.

Great, thanks!

In case you're willing to reword the commit message:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Laszlo