From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwWhW-000085-80 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwWhU-0004BL-PY for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:07:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwWhU-0004BB-Gv for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:07:20 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r69C7IQr014555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Jul 2013 08:07:19 -0400 Message-ID: <51DBFCF6.1010809@redhat.com> Date: Tue, 09 Jul 2013 06:07:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373357135-9294-1-git-send-email-kwolf@redhat.com> <20130709115808.GB2910@T430s.nay.redhat.com> In-Reply-To: <20130709115808.GB2910@T430s.nay.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SUTBLGDFHRAJUVLKAGAQ" Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: famz@redhat.com Cc: Kevin Wolf , qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SUTBLGDFHRAJUVLKAGAQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2013 05:58 AM, Fam Zheng wrote: > On Tue, 07/09 10:05, Kevin Wolf wrote: >> This removes duplicated definitions and documentation by reusing the >> existing data type. >> >> Signed-off-by: Kevin Wolf >> --- >> +++ b/qapi-schema.json >> @@ -1791,42 +1791,14 @@ >> # The operation can be stopped before it has completed using the >> # block-job-cancel command. >> # > Are these lines, ... >> -# actions will be used. >> +# For the arguments, see the documentation of DriveBackup. >> # >> # Returns: nothing on success >> # If @device is not a valid block device, DeviceNotFound >> # >> # Since 1.6 >> ## > and these still duplication of those comments for type declaration? Are you talking about the lines that were elided or the lines that remain? The lines that were elided are duplicates of the documentation of the DriveBackup struct; the lines that remain (command overview, Returns, and Since designations) must remain because they independently document the 'drive-backup' command. The trivial amount of remaining duplication (basically, the Since 1.6 line) matches what was already done for the blockdev-snapshot-sync command, because every entity (both types and commands) should mention when they were introduced. I see no problem with the patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SUTBLGDFHRAJUVLKAGAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR2/z2AAoJEKeha0olJ0Nq+pkH/j1qX/jKRKuDpo0xXfuMv9ph HaD+ni6bFrWTr4JOtv8YIhBcUR/vex+Mgn3z4NqAm5T0Yfw5862EbOf5NnqAS/2V mg8crViPV+LG20SYG/3/Hz2OkPlzVvaYc5kjDdGpCO/SIYZV1/ITe/8KdU4xRBND gR3voM9oSoL1LsmyPbjlSgZfsssIKJ17jtYbNO4AIO1knMuzg4DxFDZNF4AYRThh F3YE+gKoEVjh5yekDvCzIS7aps3RzKjItrso6D99DwBDWEGUBb3qkY4hf8hXRkq5 Ojw/48moyivcwewH3KYnAi7g4ms+non5AIGWf5sYOEeW8Fqd9dMJP6fxEunBoQ0= =yetw -----END PGP SIGNATURE----- ------enig2SUTBLGDFHRAJUVLKAGAQ--