From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments
Date: Tue, 09 Jul 2013 06:09:38 -0600 [thread overview]
Message-ID: <51DBFD82.9050304@redhat.com> (raw)
In-Reply-To: <20130709120415.GB3332@dhcp-200-207.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On 07/09/2013 06:04 AM, Kevin Wolf wrote:
>> and these still duplication of those comments for type declaration?
>
> No, the DriveBackup documentation doesn't describe what the command does
> or what it returns. You might argue that it should be there, but I think
> that's out of scope for this patch and you can do it separately if you
> like.
Besides, the DriveBackup type is usable within the 'transaction'
command, where it does NOT have an associated return type (it is just
one of many actions, where ALL actions have no return, and the overall
'transaction' command either succeeds or fails). I don't think any
separate patch is warranted here, unless you also make the same
arguments for 'blockdev-snapshot-sync'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-09 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 8:05 [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments Kevin Wolf
2013-07-09 11:47 ` Eric Blake
2013-07-09 11:58 ` Fam Zheng
2013-07-09 12:04 ` Kevin Wolf
2013-07-09 12:09 ` Eric Blake [this message]
2013-07-09 12:17 ` Kevin Wolf
2013-07-09 12:07 ` Eric Blake
2013-07-09 12:45 ` Fam Zheng
2013-07-09 13:31 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBFD82.9050304@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).