From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwWjm-0002ft-Fx for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwWjk-0004ip-Rh for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:09:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwWjk-0004id-IP for qemu-devel@nongnu.org; Tue, 09 Jul 2013 08:09:40 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r69C9ekG015188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Jul 2013 08:09:40 -0400 Message-ID: <51DBFD82.9050304@redhat.com> Date: Tue, 09 Jul 2013 06:09:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373357135-9294-1-git-send-email-kwolf@redhat.com> <20130709115808.GB2910@T430s.nay.redhat.com> <20130709120415.GB3332@dhcp-200-207.str.redhat.com> In-Reply-To: <20130709120415.GB3332@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2AAWHWEVVVMJXHLQARTNA" Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AAWHWEVVVMJXHLQARTNA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2013 06:04 AM, Kevin Wolf wrote: >> and these still duplication of those comments for type declaration? >=20 > No, the DriveBackup documentation doesn't describe what the command doe= s > or what it returns. You might argue that it should be there, but I thin= k > that's out of scope for this patch and you can do it separately if you > like. Besides, the DriveBackup type is usable within the 'transaction' command, where it does NOT have an associated return type (it is just one of many actions, where ALL actions have no return, and the overall 'transaction' command either succeeds or fails). I don't think any separate patch is warranted here, unless you also make the same arguments for 'blockdev-snapshot-sync'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2AAWHWEVVVMJXHLQARTNA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR2/2CAAoJEKeha0olJ0NqQQ0H/jN/kOii2CFkGLkFhzXnu2bk faJoM0ZYw/edC5pcF0uRCY/pBkFi1f9NWH4BLEkcSKmbQKYIrvrdmzlb5G4RlJea bjGENxDb9n/h1+MoiwgEJe0MVzqSWcvUfbeI3YZrLLOfdUORCTwDSoubylXxunGq U9xTpqdAZlRRto7uEEpAKQwsD0emBaoJIdJYQWbvlr6pN5BQ1rfJ2kvTJt/ffG2K snSBljTojjybsiLhpit1fp0WZiAyrZddEmJGRDqCxPoFGYc1+MzcwDTQtPNL4LPF +teYZVcalFNKWV6SOR1j6aKQG0wJwIUnw/BVTGoKV9BNLcYr7L/PDZMiS24lGOI= =s03i -----END PGP SIGNATURE----- ------enig2AAWHWEVVVMJXHLQARTNA--