From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYWs-00082B-5l for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:04:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwYWn-0004vn-Gl for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:04:30 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:39836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYWm-0004vO-Q5 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:04:25 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Jul 2013 19:26:47 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 57F3CE0056 for ; Tue, 9 Jul 2013 19:34:03 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r69E4nHY24903798 for ; Tue, 9 Jul 2013 19:34:50 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r69E4EYq001696 for ; Wed, 10 Jul 2013 00:04:15 +1000 Message-ID: <51DC183E.4020409@linux.vnet.ibm.com> Date: Tue, 09 Jul 2013 22:03:42 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1372477981-7512-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1372477981-7512-2-git-send-email-xiawenc@linux.vnet.ibm.com> <20130708111711.0b2631d6@redhat.com> <51DB7040.8020306@linux.vnet.ibm.com> In-Reply-To: <51DB7040.8020306@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com >> You could pass cur_mon to readline_completion() in readline_handle_byte() >> to avoid all this, but it would be preferable to clarify the matter. >> >> This is also another benefit of having readline_completion() in a >> different patch, you can (and should!) clarify this point in the commit >> log along with testing results. >> > OK, I'll test multiple monitors case. > > > Do you have an example about how invoke qemu with multiple monitor? Do you have recommendation about the way to connect to qemu's moniotr? I tried pty with minicom but it seems not good, so wonder your method. -- Best Regards Wenchao Xia