From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYyh-0000WX-PJ for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwYyf-0007h5-5J for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:33:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46557 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYye-0007gp-Rh for qemu-devel@nongnu.org; Tue, 09 Jul 2013 10:33:13 -0400 Message-ID: <51DC1F19.8030806@suse.de> Date: Tue, 09 Jul 2013 16:32:57 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1349286518-28123-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1349286518-28123-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/6] qdev: handle global properties after all instance_init calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , Igor Mammedov , Eduardo Habkost , qemu-devel@nongnu.org Ping for KVM call discussion Am 03.10.2012 19:48, schrieb Eduardo Habkost: > Summary: > - Object properties are registered by the classes' instance_init() > functions > - qdev_prop_set_globals() needs all properties to be registered before= being > called. > - Hence, qdev_prop_set_globals() can't be called from device_initfn(). >=20 > Reference: > http://article.gmane.org/gmane.comp.emulators.qemu/173753 >=20 > This series is a larger than the single-patch suggestion sent by Igor (= URL > above), just because I wanted to include a unit test for the new code. = To do > that, I pulled the qdev-split code sent previously to the list, so a qd= ev unit > test could be written without pulling too many dependencies. >=20 > Patches 1-3 are just code movement, patch 3 adds the qdev unit test, pa= tches 5-6 > finally introduce post_init(), and move the qdev_prop_set_globals() cal= l to > post_init(). >=20 > Anthony Liguori (1): > qdev: split up header so it can be used in cpu.h >=20 > Eduardo Habkost (4): > qdev: separate core from the code used only by qemu-system-* > tests: unit tests for qdev global-properties handling > qom: introduce post_init() function > qdev: set globals on post_init() function >=20 > Igor Mammedov (1): > qapi-types.h doesn't really need to include qemu-common.h >=20 > hw/Makefile.objs | 1 + > hw/irq.h | 2 + > hw/mc146818rtc.c | 1 + > hw/qdev-addr.c | 1 + > hw/qdev-core.h | 240 ++++++++++++++++++++++++++ > hw/qdev-monitor.h | 16 ++ > hw/qdev-properties-system.c | 329 +++++++++++++++++++++++++++++++++= +++ > hw/qdev-properties.c | 321 +--------------------------------= -- > hw/qdev-properties.h | 131 +++++++++++++++ > hw/qdev-system.c | 93 +++++++++++ > hw/qdev.c | 102 +---------- > hw/qdev.h | 371 +--------------------------------= -------- > include/qemu/object.h | 3 + > qom/object.c | 14 ++ > scripts/qapi-types.py | 3 +- > tests/Makefile | 6 + > tests/fake-qdev.c | 52 ++++++ > tests/test-qdev-global-props.c | 178 ++++++++++++++++++++ > 18 files changed, 1083 insertions(+), 781 deletions(-) > create mode 100644 hw/qdev-core.h > create mode 100644 hw/qdev-monitor.h > create mode 100644 hw/qdev-properties-system.c > create mode 100644 hw/qdev-properties.h > create mode 100644 hw/qdev-system.c > create mode 100644 tests/fake-qdev.c > create mode 100644 tests/test-qdev-global-props.c >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg