From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwejU-0007cE-4z for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:41:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwejS-0002IF-TR for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:41:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwejS-0002Hx-N5 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:41:54 -0400 Message-ID: <51DC758A.8020200@redhat.com> Date: Tue, 09 Jul 2013 14:41:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1371547919-15654-1-git-send-email-wdongxu@linux.vnet.ibm.com> <20130704125243.GE4213@stefanha-thinkpad.redhat.com> In-Reply-To: <20130704125243.GE4213@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2XAPTQHEXMODCBJTKMXUQ" Subject: Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, Dong Xu Wang , wdongxu@cn.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XAPTQHEXMODCBJTKMXUQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote: > On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: >> These patches will replace QEMUOptionParameter with QemuOpts. Change l= ogs >> please go to each patch's commit message. >> >> Dong Xu Wang (7): >> add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print >> avoid duplication of default value in QemuOpts >> Create four QemuOptsList related functions >> Create some QemuOpts functons >> Use QemuOpts support in block layer >> query-command-line-options outputs def_value_str >> remove QEMUOptionParameter related functions and struct >> >> V15->V16: >> 1) discard double-initialization. >> 2) use pointer directly, not g_strdup. >> 3) modify query-command-line-options related code. >> V14->V15: >> 1) Only delete enum QEMUOptionParType. >=20 > eblake: You commented on the last revision. Are you happy with v16? Apologies for my delays (still digging myself out of 3 weeks accumulation of mail after my vacation); I'll review within 24 hours. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2XAPTQHEXMODCBJTKMXUQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR3HWKAAoJEKeha0olJ0NqS88H/1p/r3Od5aqv8nh+eApsNSHl +0+rXnU9mC6xQSD5GJhXjESufGnvxe0372OKQpnqVIHdQjUvHVje+26/J93MpEjq OWgBsJEUGafAhBGJVQ+DkmrNgs7i+UKs5K/fF93H2x3DqnWw8+2LFXX4oWCMRs5n MCEZQO9soZR8Ap7RNXDJJOD9dOu8pMNYa7eNyP6pZ6AOfg+R/xl8nnMctrRAYeA3 SSPUeICQobYw62msRlnbmCeCMxjZqkIPCG0lBcSkdfKTrDvbgvmKYPvWqP7pLxpm bZb86BlEgSCqRc9Zp+ihu0T0jauRqdZ8aCfraSoxZfrXc3PannidbOLXDAAaKG0= =QGUx -----END PGP SIGNATURE----- ------enig2XAPTQHEXMODCBJTKMXUQ--