From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwtIp-0006vx-Gb for qemu-devel@nongnu.org; Wed, 10 Jul 2013 08:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwtIk-0005IZ-LS for qemu-devel@nongnu.org; Wed, 10 Jul 2013 08:15:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55114 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwtIk-0005IM-BN for qemu-devel@nongnu.org; Wed, 10 Jul 2013 08:15:18 -0400 Message-ID: <51DD5052.1040706@suse.de> Date: Wed, 10 Jul 2013 14:15:14 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1373025777-21956-1-git-send-email-jfrei@linux.vnet.ibm.com> <51DD3719.207@de.ibm.com> <6A1648DC-7BA6-4101-9B5F-BA241A56156B@suse.de> In-Reply-To: <6A1648DC-7BA6-4101-9B5F-BA241A56156B@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4] s390: Implement dump-guest-memory support for target s390x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Christian Borntraeger Cc: Jens Freimann , Ekaterina Tumanova , qemu-devel Am 10.07.2013 12:37, schrieb Alexander Graf: > On 10.07.2013, at 12:27, Christian Borntraeger wrote: >> On 05/07/13 14:02, Jens Freimann wrote: >>> With this patch dump-guest-memory on s390 produces an ELF formatted, >>> crash-readable dump. >>> In order to implement this, the arch-specific part of dump-guest-memo= ry >>> was added: >>> target-s390x/arch_dump.c contains the whole set of function for writi= ng >>> Elf note sections of all types for s390x. >>> >>> Signed-off-by: Ekaterina Tumanova >>> Signed-off-by: Jens Freimann >> Acked-by: Christian Borntraeger >> >> I can confirm that this patch creates proper dumps readable by crash w= ith valid >> memory and valid register content. Would be good to see this upstream. >> >> Meanwhile this patch no longer cleanly applies due to >> commit 878096eeb278a8ac1ccd6667af73e026f29b4cf5 >> cpu: Turn cpu_dump_{state,statistics}() into CPUState hooks >> >> The fixup is trivial. >> Alex, please apply. >=20 > I'd like to get an Ack from Andreas too :). But then I'll happily apply= it. I am mostly happy and had offered Alex to reply with a fixup patch to squash on top, but am still buried in downstream work and didn't get to preparing that yet: v4 started #including cpu-qom.h, which it shouldn't (only cpu.h does in the tree) - if Alex wants to drop that line himself, please add my Reviewed-by on top, Alex. I did not check whether the s390x implementation is functionally correct, just the changed API and any style issues. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg