From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwv3u-0005cY-Ki for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:08:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwv3o-0002ob-JW for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:08:06 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:57815 helo=mx01.kamp.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Uwv3o-0002oP-8P for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:08:00 -0400 Message-ID: <51DD6ABC.9060004@kamp.de> Date: Wed, 10 Jul 2013 16:07:56 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1372338695-411-1-git-send-email-pl@kamp.de> <1372338695-411-10-git-send-email-pl@kamp.de> <20130710112916.GJ3898@dhcp-200-207.str.redhat.com> In-Reply-To: <20130710112916.GJ3898@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 09/11] iscsi: factor out sector conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 10.07.2013 13:29, schrieb Kevin Wolf: > Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: >> Signed-off-by: Peter Lieven >> --- >> block/iscsi.c | 18 +++++++++++------- >> 1 file changed, 11 insertions(+), 7 deletions(-) > A bit confusing that you add only one function (because the other one is > already there), but convert both directions. Looks correct, though. this is because qemu_sector2lun was only used for the lba, but never for nb_sectors by Ronnie. Peer > > Reviewed-by: Kevin Wolf