From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uwww3-0004ZI-Cu
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:08:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uwwvx-0001uI-9Z
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:08:07 -0400
Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:53189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uwwvx-0001uA-5W
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:08:01 -0400
Received: by mail-qa0-f41.google.com with SMTP id f14so7056419qak.7
	for <qemu-devel@nongnu.org>; Wed, 10 Jul 2013 09:08:00 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51DD86DC.5070409@twiddle.net>
Date: Wed, 10 Jul 2013 09:07:56 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <51DD7454.4020204@huawei.com>
In-Reply-To: <51DD7454.4020204@huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 0/1] ARM aarch64 TCG tlb fast lookup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jani Kokkonen <Jani.Kokkonen@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Claudio Fontana <claudio.fontana@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 07/10/2013 07:48 AM, Jani Kokkonen wrote:
> 
> This patch implements the TCG tlb fast lookup in 
> tcg_out_qemu_ld/st for the aarch64 TCG target.  
> Supports also CONFIG_QEMU_LDST_OPTIMIZATION.
> 
> Tested running on a x86-64 physical machine running Foundation v8,
> running a linux 3.2.0 minimal host system based on linaro v8
> image build 0.8.4423 for user space.
> 
> Tested guests: arm v5, PPC64, sparc, i386 linux test images.
> Also tested on x86-64/linux built with buildroot.
> 
> Changes in v2:
> -Fix whitespace and indentation
> -Pass mem_index into tcg_out_tlb_read() and calculate tlb_offset inside  
>  tcg_out_tlb_read() 
> -Add comments in tcg_out_tlb_read() 
> -Change parameter type from int to TCGREg for data_reg and addr_reg parameters
>  in add_qemu_ldst_label()
> -Use extended register for tcg_out_cmp() in tcg_out_tlb_read() only if needed  
>   
> 
> Jani Kokkonen (1):
>   tcg/aarch64: Implement tlb lookup fast path
> 
>  configure                |    2 +-
>  include/exec/exec-all.h  |   14 +++
>  tcg/aarch64/tcg-target.c |  224 +++++++++++++++++++++++++++++++++++-----------
>  3 files changed, 189 insertions(+), 51 deletions(-)
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~