From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwxdl-0004qF-B5 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:53:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwxdh-0000ZF-T7 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:53:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwxdh-0000Z8-K8 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 12:53:13 -0400 Message-ID: <51DD9119.9000408@redhat.com> Date: Wed, 10 Jul 2013 10:51:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1371547919-15654-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1371547919-15654-5-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1371547919-15654-5-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2IFCFOJKNDPXOHQMEOXIT" Subject: Re: [Qemu-devel] [PATCH V16 4/7] Create some QemuOpts functons List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Xu Wang Cc: kwolf@redhat.com, wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2IFCFOJKNDPXOHQMEOXIT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/18/2013 03:31 AM, Dong Xu Wang wrote: > These functions will be used in next commit. >=20 > qemu_opt_get_(*)_del functions are used to make sure we > have the same behaviors as before: in block layer, after > parsing a parameter value, parameter list will delete it > to avoid parsing it twice. >=20 > Signed-off-by: Dong Xu Wang > --- > +++ b/util/qemu-option.c > @@ -33,6 +33,8 @@ > #include "qapi/qmp/qerror.h" > #include "qemu/option_int.h" > =20 > +static void qemu_opt_del(QemuOpt *opt); > + Is it possible to implement this function in a topological order that avoids the need for a forward declaration? But not a show-stopper. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2IFCFOJKNDPXOHQMEOXIT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR3ZEZAAoJEKeha0olJ0Nq0ZUH/1Z5rzCwiQ0ASOUy9uj/L14I d3kY1uL9zVZeZ9cDTwYg9B1H6cq4MF00SL/Q66kpF9ropxwFTOmlRZle3LMU2ofc S/xSiJPWHUHnMKK9HpPbUD7KUmoPgifKDAhFyFAgemv3WrHpV+c1s1ucPS04104C 5EeMPY/Fn1CPY05ZmZF8UhSMa6juUFOzz29qd0AXT7XivwiJ7Cq99srKqXQwX1xp YGK9trzshwF+NixcKRX++gqnFi6jnQLqxAYdu9oDgUw6qRdoAyevjHBoPOAxJZ+a HK5/rtOloLAepZGBvG/HPE2PxXAIzLgZIqS53IiCaHn+h00LyoJCfmnnsBlE+NU= =clQp -----END PGP SIGNATURE----- ------enig2IFCFOJKNDPXOHQMEOXIT--