From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwy8R-00035s-9J for qemu-devel@nongnu.org; Wed, 10 Jul 2013 13:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwy8Q-0002vf-BP for qemu-devel@nongnu.org; Wed, 10 Jul 2013 13:24:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwy53-000214-58 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 13:21:29 -0400 Message-ID: <51DD97F0.8060001@redhat.com> Date: Wed, 10 Jul 2013 11:20:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373268366-14508-1-git-send-email-cngesaint@gmail.com> <20130710111303.GG18465@T430s.nay.redhat.com> <20130710114250.GM3898@dhcp-200-207.str.redhat.com> In-Reply-To: <20130710114250.GM3898@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2PHEFETAUADHOABEKRJPV" Subject: Re: [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: stefanha@gmail.com, Xu Wang , Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PHEFETAUADHOABEKRJPV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/10/2013 05:42 AM, Kevin Wolf wrote: >> Thanks for the series. I made a few comments on each patch. You hashed= >> windows full path to get the "inode", but case sensitively, would that= >> work with the same files of different case? >=20 > I seem to remember that Windows can be made case-sensitive. In this > case, we must not ignore case. Not detecting some loops is okay (but he= re > we would in fact detect it in the second iteration), rejecting valid > configurations is not. Indeed, Windows can be made case-sensitive. But you still want to hash case-insensitive, and just be careful to not report collisions until after checking inode equality. For that matter, stat() on windows is notoriously lame (such as returning 0 for st_ino on FAT, regardless of file). While I've compiled on windows, it has generally been on cygwin (where they go to great lengths to give a sane stat() in spite of FAT's shortcomings); you may want to get a review from someone more intimately acquainted with mingw (Paolo?), in case there is no way to make inode equality work, and where you may be better off with absolute path name comparison. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2PHEFETAUADHOABEKRJPV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR3ZfwAAoJEKeha0olJ0Nqj6YH/jbbnC5TU2giW0L6QFbfgOVk zx4au4HThmsfjLvLwp/q7kW8xFzAK0wMuxnHuklIjOHOq7LEDLVkjSjFQOxV66LE JC7HzHlnMT2M4Tstc0fF+wcgVB1FdSh2pgdDl9Jz+d/c9lA3d+YlAc0qFuI6vUdJ G6CmPOTcaU7HWlVeyK64MdvYCQcAEtfLOyvuSKdAr8yDU3DcPwr8SXeQrZTG0vv+ AgzNVwIfEsz7wEd56wdqCL54brSeCBRNfS9/f4UUI+xnHCA918x0kttwjIl1qU11 8FlnwLynByd0yKY/TKJki4pobu68BELKVyB3eUTTXe/sOSUhzPUsaOBakkfYXi8= =0L+k -----END PGP SIGNATURE----- ------enig2PHEFETAUADHOABEKRJPV--