From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ux0Ny-0002pZ-EE for qemu-devel@nongnu.org; Wed, 10 Jul 2013 15:49:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ux0Nx-0005LR-7a for qemu-devel@nongnu.org; Wed, 10 Jul 2013 15:49:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ux0Nw-0005LI-V2 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 15:49:09 -0400 Message-ID: <51DDBAAD.3070808@redhat.com> Date: Wed, 10 Jul 2013 13:49:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1371547919-15654-1-git-send-email-wdongxu@linux.vnet.ibm.com> <20130704125243.GE4213@stefanha-thinkpad.redhat.com> <51DC758A.8020200@redhat.com> In-Reply-To: <51DC758A.8020200@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BEBEGKAXCAXIFPEUUKXI" Subject: Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Dong Xu Wang , Stefan Hajnoczi , wdongxu@cn.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BEBEGKAXCAXIFPEUUKXI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2013 02:41 PM, Eric Blake wrote: > On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote: >> On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: >>> These patches will replace QEMUOptionParameter with QemuOpts. Change = logs >>> please go to each patch's commit message. >>> >>> Dong Xu Wang (7): >>> add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print= >>> avoid duplication of default value in QemuOpts >>> Create four QemuOptsList related functions >>> Create some QemuOpts functons >>> Use QemuOpts support in block layer >>> query-command-line-options outputs def_value_str >>> remove QEMUOptionParameter related functions and struct >>> >=20 >>> V15->V16: >>> 1) discard double-initialization. >>> 2) use pointer directly, not g_strdup. >>> 3) modify query-command-line-options related code. >>> V14->V15: >>> 1) Only delete enum QEMUOptionParType. >> >> eblake: You commented on the last revision. Are you happy with v16? >=20 > Apologies for my delays (still digging myself out of 3 weeks > accumulation of mail after my vacation); I'll review within 24 hours. At this point, I think a v17 is warranted (comments on individual patches= ). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BEBEGKAXCAXIFPEUUKXI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR3bqtAAoJEKeha0olJ0NqXM8H/jd+hADI3hklRNYgRgMmm3qj dsmCpjH+iDazMzFUbtGzpFVonQRW+QhcCQUqqKZhAdCQ12KHepz3wYEs/nYGKvfH P8mZcEJwj+Vqdp9V9qSAee/IOkNcrO58OgB5+gVZZb4S1mUT2IYCNwkPM2/JlbI+ HdhFTvaeqXAjJS3ok5O62GOtkpYLR/nYzS+kmJ95r35KwEqZdhZlynujGG3szgJp C8yxNsQbdLU7XGUWUbvXxn6aWF14eZt3WmiP/f+qTwHaen9JbgSRpYBGHxPfgEXf nDAtCCOBvOW3q9962k4d2mlfEsoQv7K7/tMWNMUFWDQiL6uaaAtuiyZ+SDtSmnQ= =uxaU -----END PGP SIGNATURE----- ------enig2BEBEGKAXCAXIFPEUUKXI--