qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Paul Moore <pmoore@redhat.com>
Cc: qemu-stable <qemu-stable@nongnu.org>,
	coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	otubo@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist
Date: Wed, 10 Jul 2013 22:02:55 +0200	[thread overview]
Message-ID: <51DDBDEF.7060209@suse.de> (raw)
In-Reply-To: <1536749.nyBeeYseQi@sifl>

Am 10.07.2013 16:31, schrieb Paul Moore:
> On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote:
>> In order to enable the asynchronous I/O functionality when using the
>> seccomp sandbox we need to add the associated syscalls to the
>> whitelist.
>>
>> Signed-off-by: Paul Moore <pmoore@redhat.com>
>> ---
>>  qemu-seccomp.c |    5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>> index 031da1d..ca123bf 100644
>> --- a/qemu-seccomp.c
>> +++ b/qemu-seccomp.c
>> @@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
>> = { { SCMP_SYS(stat), 245 },
>>      { SCMP_SYS(uname), 245 },
>>      { SCMP_SYS(eventfd2), 245 },
>> +    { SCMP_SYS(io_getevents), 245 },
>>      { SCMP_SYS(dup), 245 },
>>      { SCMP_SYS(dup2), 245 },
>>      { SCMP_SYS(dup3), 245 },
>> @@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall
>> seccomp_whitelist[] = { { SCMP_SYS(sendmmsg), 241 },
>>      { SCMP_SYS(recvmmsg), 241 },
>>      { SCMP_SYS(prlimit64), 241 },
>> -    { SCMP_SYS(waitid), 241 }
>> +    { SCMP_SYS(waitid), 241 },
>> +    { SCMP_SYS(io_setup), 241 },
>> +    { SCMP_SYS(io_destroy), 241 }
>>  };
>>
>>  int seccomp_start(void)
> 
> Any reason this patch wasn't pulled in for 1.5.1?

Yes: You forget to put a line Cc: qemu-stable@nongnu.org into the commit
message nor was it ever CC'ed while on the list. ;)

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-07-10 20:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 20:30 [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist Paul Moore
2013-05-29 21:16 ` Corey Bryant
2013-05-31 18:48 ` Anthony Liguori
2013-07-10 14:31 ` Paul Moore
2013-07-10 20:02   ` Andreas Färber [this message]
2013-07-10 20:19     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DDBDEF.7060209@suse.de \
    --to=afaerber@suse.de \
    --cc=coreyb@linux.vnet.ibm.com \
    --cc=otubo@linux.vnet.ibm.com \
    --cc=pmoore@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).