From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37104)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UxDbO-0003sp-K3
	for qemu-devel@nongnu.org; Thu, 11 Jul 2013 05:55:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UxDbM-0007cy-TU
	for qemu-devel@nongnu.org; Thu, 11 Jul 2013 05:55:54 -0400
Message-ID: <51DE811F.3000802@suse.de>
Date: Thu, 11 Jul 2013 11:55:43 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1373466860-32732-1-git-send-email-afaerber@suse.de>
	<1373466860-32732-10-git-send-email-afaerber@suse.de>
	<CAETRQWm+s+zrOFv9_RFYJnSuijVYUU6RiSsW1K26uGzT0pUhTA@mail.gmail.com>
In-Reply-To: <CAETRQWm+s+zrOFv9_RFYJnSuijVYUU6RiSsW1K26uGzT0pUhTA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 09/43] cpu: Make first_cpu and next_cpu
	CPUState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: TeLeMan <geleman@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Igor Mitsyanko <i.mitsyanko@samsung.com>, Gleb Natapov <gleb@redhat.com>, Evgeny Voevodin <e.voevodin@samsung.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, Peter Crosthwaite <peter.crosthwaite@petalogix.com>, Mark Langsdorf <mark.langsdorf@calxeda.com>, Alexander Graf <agraf@suse.de>, qemu-ppc <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>, Scott Wood <scottwood@freescale.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Maksim Kozlov <m.kozlov@samsung.com>, Aurelien Jarno <aurelien@aurel32.net>, Dmitry Solodkiy <d.solodkiy@samsung.com>

Am 11.07.2013 11:14, schrieb TeLeMan:
> On Wed, Jul 10, 2013 at 10:33 PM, Andreas F=C3=A4rber <afaerber@suse.de=
> wrote:
>> diff --git a/gdbstub.c b/gdbstub.c
>> index f7d9f13..0ee82a9 100644
>> --- a/gdbstub.c
>> +++ b/gdbstub.c
[...]
>> @@ -2394,7 +2401,7 @@ static int gdb_handle_packet(GDBState *s, const =
char *line_buf)
>>              put_packet(s, "QC1");
>>              break;
>>          } else if (strcmp(p,"fThreadInfo") =3D=3D 0) {
>> -            s->query_cpu =3D first_cpu;
>> +            s->query_cpu =3D first_cpu->env_ptr;
>>              goto report_cpuinfo;
>>          } else if (strcmp(p,"sThreadInfo") =3D=3D 0) {
>>          report_cpuinfo:
>> @@ -2402,7 +2409,7 @@ static int gdb_handle_packet(GDBState *s, const =
char *line_buf)
>>                  snprintf(buf, sizeof(buf), "m%x",
>>                           cpu_index(ENV_GET_CPU(s->query_cpu)));
>>                  put_packet(s, buf);
>> -                s->query_cpu =3D s->query_cpu->next_cpu;
>> +                s->query_cpu =3D ENV_GET_CPU(s->query_cpu)->next_cpu-=
>env_ptr;
> next_cpu may be NULL.

True. If this is the only place where you've found that mistake then the
implicit fix is already queued next on qom-cpu:
http://patchwork.ozlabs.org/patch/255756/

Review and/or testing of the remaining gdbstub patches would be appreciat=
ed:
http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg01510.html
Mainly I'm waiting on an ack or feedback for the vaddr typedef to proceed=
.

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg